Fuel for OpenStack

Turn on rspec test coverage reporting for fuel-library noop tests

Bug #1506557 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
Wishlist
Dmitry Ilyin
Fuel for OpenStack 10.0
Mitaka
Won't Fix
Wishlist
Dmitry Ilyin
Fuel for OpenStack 9.0

Bug Description

In order to gather metrics around how much of our puppet code is covered by noop tests, we should enable rspec coverage reporting for our noop tests and for any unit tests for modules within fuel-library.

This can be done by adding 'at_exit { RSpec::Puppet::Coverage.report! }' to the spec_helper.rb files

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/235532

Changed in fuel:
status: Confirmed → In Progress
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/235532
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=4847f1478dad9c5330b31ca61289cd69fa685067
Submitter: Jenkins
Branch: master

commit 4847f1478dad9c5330b31ca61289cd69fa685067
Author: Alex Schultz <email address hidden>
Date: Thu Oct 15 13:21:00 2015 -0500

    Add coverage reports to tests

    This change adds simplecov to show the coverage of the noop test files
    and also includes the output from the rspec-puppet reports into the
    coverage/ folder.

    The simplecov report is a report that is merged together based on the
    entire noop test run. It will show where we have astute.yaml gaps for
    our given noop spec tests.

    The rspec-puppet reports are named based on the astute.yaml file that
    was used to generate each report.

    Change-Id: I9dda550c960fb2742f1f0862305e144a3fb1d9d6
    Closes-Bug: #1506557

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix proposed to fuel-infra/jenkins-jobs (master)

Related fix proposed to branch: master
Change author: Alex Schultz <email address hidden>
Review: https://review.fuel-infra.org/13274

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-library (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/252501

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/256119

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Alexey Shtokolov (<email address hidden>) on branch: master
Review: https://review.openstack.org/252501
Reason: Due to https://review.openstack.org/#/c/256119/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/256119
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e30a4e635294bcf19ce2cc3d5b9fac36cd347112
Submitter: Jenkins
Branch: master

commit e30a4e635294bcf19ce2cc3d5b9fac36cd347112
Author: Alex Schultz <email address hidden>
Date: Thu Dec 10 15:29:24 2015 -0700

    Enable coverage report generation for Jenkins

    This change fixes the regression introduced by
    I814667283ccfc6ebd7c16d961270f688e9fb9c4c in which the rspec coverage
    information was no longer being written out. Additionally this change
    enables coverage report information to be generaged by the Jenkins jobs
    as part of the default run via fuel_noop_tests.sh. This change will
    allow us to update the jobs to capture the information with Jenkins and
    report on trends.

    Change-Id: I6cc729d7ff2928bdf78ee17487f2158b4ef12490
    Closes-Bug: #1524967
    Related-Bug: #1506557

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Related fix merged to fuel-infra/jenkins-jobs (master)

Reviewed: https://review.fuel-infra.org/13274
Submitter: Igor Belikov <email address hidden>
Branch: master

Commit: 5fdc254c880fb4117daf4b4ce7b95a77a45ce80a
Author: Alex Schultz <email address hidden>
Date: Fri Nov 20 17:52:39 2015

Capture coverage report information

This change adds the coverage report publisher for the fuellib noop job
and also archives the rspec coverage report information as well.

Change-Id: Idcd21d547dcf4c667658f8f6ff15ca31fa9a2d01
Related-Bug: #1506557

Revision history for this message
Nastya Urlapova (aurlapova) wrote :

As far I understood after discussion with Igor, infra-team should do some aliment.

Changed in fuel:
status: Fix Committed → Confirmed
milestone: 8.0 → 9.0
Revision history for this message
Igor Belikov (ibelikov) wrote :

To actually capture this in jenkins job the report must be in rcov format, could be solved using https://rubygems.org/gems/simplecov-rcov/

Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
Maksim Malchuk (mmalchuk)
no longer affects: fuel/newton
Changed in fuel:
assignee: Alex Schultz (alex-schultz) → Fuel Sustaining (fuel-sustaining-team)
assignee: Fuel Sustaining (fuel-sustaining-team) → Dmitry Ilyin (idv1985)
Dmitry Ilyin (idv1985)
Changed in fuel:
importance: Medium → Low
Dmitry Ilyin (idv1985)
Changed in fuel:
importance: Low → Wishlist
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.