congress

test_policy assumes oslo.policy internal implementationd details

Bug #1505750 reported by Tim Hinrichs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Tim Hinrichs
congress mitaka-1 "mitaka-1"

Bug Description

Congress's test_policy assumes that oslo.policy uses urlrequest.urlopen(), just like Neutron used to do. The mitaka release changes those internals and hence our tests fail.

Here's the same bug filed for Neutron.

https://bugs.launchpad.net/neutron/+bug/1503890

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/234367

Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/233506
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=6474767b17b128b583c9758d69c878873685f7a1
Submitter: Jenkins
Branch: master

commit 6474767b17b128b583c9758d69c878873685f7a1
Author: Yingxin Cheng <email address hidden>
Date: Mon Oct 12 14:58:03 2015 +0800

    Change devstack to OS_PROJECT_NAME and avoid mocking oslo.policy internals

    To pass the tests in gate, this commit has 2 separate changes

    1) OS_TENANT_NAME is no longer used in the latest devstack, it causes all
    datasource driver fail, as well as jenkins gate failure.

    This fix changes devstack to use OS_PROJECT_NAME

    2) Previously, we tested oslo.policy by mocking out one of the internals
    of oslo.policy, just like Neutron. Besides being improper, the newest
    release of oslo.policy broke that test, which is what is blocking
    the tip of master currently.

    This fix shamelessly copies the fix out of Neutron, mocking out
    at the layer of HTTPCheck.

    Change-Id: I2a4eae714946ce98a060a43dd501b9b3619aa68e
    Closes-Bug: #1505057
    Closes-bug: #1505750

Changed in congress:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on congress (master)

Change abandoned by Tim Hinrichs (<email address hidden>) on branch: master
Review: https://review.openstack.org/234367
Reason: Rolled into another change to unbreak the gate

Tim Hinrichs (thinrichs)
Changed in congress:
status: Fix Committed → Fix Released
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → mitaka-1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.