OpenStack Services functions should have its name with first letter lowercased

Bug #1501860 reported by Rajat Vig
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Rajat Vig

Bug Description

OpenStack Services functions are not constructor functions therefor shouldn't have the name with first letter capitalized.
It should be with lower cased.

Changed in horizon:
assignee: nobody → Rajat Vig (rajatv)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/216891
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=60ba21795124a3a10045a9b037988addbeacea6c
Submitter: Jenkins
Branch: master

commit 60ba21795124a3a10045a9b037988addbeacea6c
Author: Rajat Vig <email address hidden>
Date: Thu Oct 1 11:06:06 2015 -0700

    Uncapitalize the first letter of non init functions

    Several files contain capital letters instead of lower case ones in
    non init functions as discussed here:
    https://review.openstack.org/#/c/216443/3/openstack_dashboard/static/app/core/openstack-service-api/heat.service.js

    Change-Id: I79d7eaaa11c9475184ede580d10cc5fd2bc3ded7
    Closes-Bug: #1501860

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/23433
Submitter: Vinay Vithal Mahuli (<email address hidden>)

Vinay Mahuli (vmahuli)
no longer affects: juniperopenstack/trunk
no longer affects: juniperopenstack
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.