"Request cancelled" error messages using ListView
Bug #1501349 reported by
Arthur Mello
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Alejandro J. Cura | ||
| Thumbnailer |
Fix Released
|
High
|
Michi Henning | ||
Bug Description
While running the attached qml app to test the fixes for bug #1484914 in krillin with --channel=
ThumbnailerImag
"Request cancelled"
To run it make sure you have at least 100 photos in /home/phablet/
$ phablet-shell
$ qmlscene --desktop_
Related branches
lp://staging/~michihenning/thumbnailer/request-cancellation
- James Henstridge: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 1495 lines (+570/-158)23 files modifieddata/com.canonical.Unity.Thumbnailer.gschema.xml (+8/-0)
debian/changelog (+2/-0)
debian/libthumbnailer-qt1.0.symbols (+1/-0)
include/internal/thumbnailer.h (+1/-24)
include/ratelimiter.h (+8/-3)
include/settings.h (+2/-0)
include/unity/thumbnailer/qt/thumbnailer-qt.h (+12/-6)
man/thumbnailer-settings.5 (+25/-12)
plugins/Ubuntu/Thumbnailer.0.1/thumbnailerimageresponse.cpp (+1/-1)
src/libthumbnailer-qt/libthumbnailer-qt.cpp (+99/-46)
src/ratelimiter.cpp (+23/-11)
src/service/dbusinterface.cpp (+3/-3)
src/service/dbusinterface.h (+2/-2)
src/service/handler.cpp (+19/-9)
src/service/handler.h (+1/-1)
src/settings.cpp (+14/-0)
src/thumbnailer.cpp (+24/-0)
src/vs-thumb/thumbnailextractor.cpp (+1/-1)
tests/libthumbnailer-qt/CMakeLists.txt (+2/-0)
tests/libthumbnailer-qt/libthumbnailer-qt_test.cpp (+189/-16)
tests/stress/stress_test.cpp (+109/-23)
tests/thumbnailer/thumbnailer_test.cpp (+19/-0)
tools/parse-settings.py (+5/-0)
Revision history for this message
| Arthur Mello (artmello) wrote | #1 |
| Changed in canonical-devices-system-image: | |
| milestone: | none → ww46-2015 |
| assignee: | nobody → Alejandro J. Cura (alecu) |
| importance: | Undecided → High |
Revision history for this message
| Michi Henning (michihenning) wrote | #2 |
| Changed in thumbnailer: | |
| assignee: | nobody → James Henstridge (jamesh) |
Revision history for this message
| Albert Astals Cid (aacid) wrote | #3 |
Revision history for this message
| Michi Henning (michihenning) wrote | #4 |
Revision history for this message
| Michi Henning (michihenning) wrote | #5 |
| Changed in thumbnailer: | |
| assignee: | James Henstridge (jamesh) → Michi Henning (michihenning) |
| Changed in thumbnailer: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| Changed in canonical-devices-system-image: | |
| status: | New → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #6 |
| Changed in thumbnailer: | |
| status: | In Progress → Fix Committed |
| Changed in thumbnailer: | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This could be related to the request limiter inside the thumbnailer. (I'm guessing here only, I haven't tried this yet.)
One of the first things to try would be with this branch: lp:~michihenning/thumbnailer/qt-rate-limiter ⇒ lp:thumbnailer/devel
That will at least narrow the problem down. If bug persists with this, I have no idea where the problem might be right now. But I'd love to know how we can provoke the QML side to call cancel() on a request. (Right now, this is essentially untested because we simply don't know how to make that happen.) Albert, could you help out with that?