Applications don't free resources upon deletion

Bug #1499563 reported by Stan Lagun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Stan Lagun
Liberty
Fix Released
High
Stan Lagun
Mitaka
Fix Released
High
Stan Lagun

Bug Description

When application that was previously deployed get removed from environment all its allocated OpenStack resources will remain allocated until whole environment get deleted

Stan Lagun (slagun)
Changed in murano:
milestone: none → liberty-rc2
assignee: nobody → Stan Lagun (slagun)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/227610

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/227916

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/227610
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=5eb3b5695b3136f061e674e5451446e2923b8937
Submitter: Jenkins
Branch: master

commit 5eb3b5695b3136f061e674e5451446e2923b8937
Author: Stan Lagun <email address hidden>
Date: Fri Sep 25 03:14:35 2015 +0300

    Release resources allocated to the Instance when it gets deleted

    Currently when application get deleted its servers are also get deleted,
    but all underlying allocated OpenStack resources remain so.

    This commit makes the following to happen upon deletion:
    * Exclude OS::Nova::Server resource from the stack
    * Exclude all FloatingIP and related resources allocated for the server
    * Exclude Neutron ports allocated to the server
    * Exclude all Heat Software Configs (in case of HeatSWConfigInstance)
       created by the app
    * Exclude all HOT template outputs related to deleted resources

    Also:
    * Instance class gets releaseResources method that can be used by apps to explicitly
      destroy the server. It can be recreated later again using deploy method
    * The order in which .destroy() methods get called was changed so that the owner's
       destructor be called before that of the owned object. For example application
       destructor will be executed prior to its Instance destructor. This allows application
       to delete all references to the server that is going to be destroyed. Thus Heat template
       remains consistent.

    Change-Id: I42d9adf827688232d89b7f01ee1176e3151c65a1
    Closes-Bug: #1499563

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/228268

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano (master)

Reviewed: https://review.openstack.org/228268
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=c997fcd6a2b7202987e9677988b681cbd12ad421
Submitter: Jenkins
Branch: master

commit c997fcd6a2b7202987e9677988b681cbd12ad421
Author: Victor Ryzhenkin <email address hidden>
Date: Sun Sep 27 22:16:53 2015 +0300

    Add test for resources deallocation

    - Add test for resources deallocation after application removed from instance

    Change-Id: I2ea25b4fd8fb180624259fe4078ac5ddaa4c9bf3
    Related-Bug: #1499563

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano (stable/liberty)

Related fix proposed to branch: stable/liberty
Review: https://review.openstack.org/228418

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/liberty)

Reviewed: https://review.openstack.org/227916
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=41437810262b9e008af4fa722984897b5ad36a38
Submitter: Jenkins
Branch: stable/liberty

commit 41437810262b9e008af4fa722984897b5ad36a38
Author: Stan Lagun <email address hidden>
Date: Fri Sep 25 03:14:35 2015 +0300

    Release resources allocated to the Instance when it gets deleted

    Currently when application get deleted its servers are also get deleted,
    but all underlying allocated OpenStack resources remain so.

    This commit makes the following to happen upon deletion:
    * Exclude OS::Nova::Server resource from the stack
    * Exclude all FloatingIP and related resources allocated for the server
    * Exclude Neutron ports allocated to the server
    * Exclude all Heat Software Configs (in case of HeatSWConfigInstance)
       created by the app
    * Exclude all HOT template outputs related to deleted resources

    Also:
    * Instance class gets releaseResources method that can be used by apps to explicitly
      destroy the server. It can be recreated later again using deploy method
    * The order in which .destroy() methods get called was changed so that the owner's
       destructor be called before that of the owned object. For example application
       destructor will be executed prior to its Instance destructor. This allows application
       to delete all references to the server that is going to be destroyed. Thus Heat template
       remains consistent.

    Change-Id: I42d9adf827688232d89b7f01ee1176e3151c65a1
    Closes-Bug: #1499563

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano (stable/liberty)

Reviewed: https://review.openstack.org/228418
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=2f34d425669c32a7c892a39192ea68cad58cbc5a
Submitter: Jenkins
Branch: stable/liberty

commit 2f34d425669c32a7c892a39192ea68cad58cbc5a
Author: Victor Ryzhenkin <email address hidden>
Date: Sun Sep 27 22:16:53 2015 +0300

    Add test for resources deallocation

    - Add test for resources deallocation after application removed from instance

    Change-Id: I2ea25b4fd8fb180624259fe4078ac5ddaa4c9bf3
    Related-Bug: #1499563
    (cherry picked from commit c997fcd6a2b7202987e9677988b681cbd12ad421)

tags: added: in-stable-liberty
Changed in murano:
milestone: liberty-rc2 → 1.0.0
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.