client-asks-for-username-password-incorrectly
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Glance Client |
Fix Released
|
High
|
Flavio Percoco | ||
Liberty |
Fix Committed
|
High
|
Flavio Percoco |
Bug Description
In solum, we use glance to store the docker images that we create for an application. We are using glance client internally to upload these images. Till recently, 'glance image-create' with only token has been happily working for us (in devstack). Today started noticing that glance image-create with just token is not working anymore. It is also not working when os-auth-token and os-image-url are passed in. According to the documentation (http://
I investigated the issue a bit.
It seems to be in this call https:/
Note that the first call to _get_endpoint_
Changed in python-glanceclient: | |
assignee: | nobody → wangxiyuan (wangxiyuan) |
Changed in python-glanceclient: | |
assignee: | wangxiyuan (wangxiyuan) → nobody |
Changed in python-glanceclient: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: 1.0.0-potential |
Changed in python-glanceclient: | |
assignee: | nobody → Flavio Percoco (flaper87) |
Changed in python-glanceclient: | |
milestone: | none → 1.2.0 |
status: | Fix Committed → Fix Released |
The reason is that the client try to check whether the action is authentication required everytime.
But now, every action is authentication required according to: /github. com/openstack/ python- glanceclient/ blob/master/ glanceclient/ common/ utils.py# L254
https:/
because every action doesn't have skip_authentication decorator. So I think we should have a discuess about:
1. Is it still need to check authentication required once user supply token and url?
2. If no, this only need a bug to fix.
2. If yes, which kind of action need to be check, and which not? We should add skip_authentication decorator to those who doesn't need check. In this case , I think we need a bp.