Murano

Improve logo validation during package uploading

Bug #1497257 reported by Ekaterina Chernova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Stan Lagun
Murano mitaka-rc1 "RC1"

Bug Description

1) Enable logo to be not only in PNG format (jpeg should also need to be allowed at least)
2) Add restriction on logo size to be <= 500 Kb

See original description
Ekaterina Chernova (efedorova)
Changed in murano:
importance: Undecided → Low
Rohini Choudhary (enthurohini)
Changed in murano:
assignee: nobody → Rohini Choudhary (enthurohini)
Revision history for this message
Rohini Choudhary (enthurohini) wrote :

Hello Ekaterina Chernova,

I am unable to find the file where the logo validations are defined. Please help me out.

Revision history for this message
Ekaterina Chernova (efedorova) wrote :

Hi!

here it is https://github.com/openstack/murano/blob/29dd968da5a6307f46e4005b8b31416375ceb0b8/murano/packages/package_base.py#L116

please, contact me by mail or irc directly is you have any questions

Ekaterina Chernova (efedorova)
Changed in murano:
milestone: next → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/240080

Changed in murano:
assignee: Rohini Choudhary (enthurohini) → Akanksha Srivastava (akanksha-dlf)
status: Confirmed → In Progress
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: mitaka-1 → mitaka-2
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: mitaka-2 → mitaka-3
Stan Lagun (slagun)
Changed in murano:
assignee: Akanksha Srivastava (akanksha-dlf) → nobody
status: In Progress → New
importance: Low → Medium
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: mitaka-3 → mitaka-rc1
Stan Lagun (slagun)
description: updated
Changed in murano:
assignee: nobody → Stan Lagun (slagun)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/240080
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=a1e546a23abb3064e4f9e43f3fde7a6b9448bf15
Submitter: Jenkins
Branch: master

commit a1e546a23abb3064e4f9e43f3fde7a6b9448bf15
Author: Akanksha <email address hidden>
Date: Thu Oct 29 04:43:03 2015 +0530

    Improve logo validation during package uploading

    Used PIL to allow support for png, jpeg and gif file formats
    for upload. An exception is raised if the image size exceeds
    500 KiB.

    Change-Id: Ifd2b8bf689214022664b7bccf846c0de63cc0bfe
    Closes-Bug:1497257

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/292026

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/292026
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=b92b7e6add92ace1b8a06760feaab5187baf15ec
Submitter: Jenkins
Branch: master

commit b92b7e6add92ace1b8a06760feaab5187baf15ec
Author: Akanksha <email address hidden>
Date: Sat Mar 12 20:29:19 2016 +0530

    Adds a test for logo validation

    Added tests for new logo validation behaviour which
    restricts file type of the logo image uploaded.
    Also fix i18 import in package_base.py

    Closes-Bug: #1497257
    Related-Bug: #1560547
    Change-Id: I772e4b1fc56de86171938a536197b253a131645c

Kirill Zaitsev (kzaitsev)
tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 3.0.0.0b1

This issue was fixed in the openstack/murano 3.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.