Some KeyError messages are using wrong format

Bug #1495343 reported by Zhenzan Zhou
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
Undecided
Zhenzan Zhou

Bug Description

Some KeyError message are using wrong format, so we cannot get the exact message from client side.
E.g.

raise KeyError("Modal %s has no entries", modal) <== it should not use comma here

Another case:

except KeyError:
    ...
    return error_response(httplib.NOT_FOUND, 404, 'Not found') <== KeyError message is not sent to client

Changed in congress:
assignee: nobody → Zhenzan Zhou (zhenzan-zhou)
Changed in congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/221628
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=1007b70d97bdf4f61c52b395ad386a4e33010e3c
Submitter: Jenkins
Branch: master

commit 1007b70d97bdf4f61c52b395ad386a4e33010e3c
Author: Zhenzan Zhou <email address hidden>
Date: Wed Sep 9 16:21:27 2015 +0800

    Fix KeyError message format

    Some KeyError exception instances are using wrong message format
    which make them not displayed in final error message.

    Change-Id: Ie83ac18660e1b08f96a4427ecbd90747df2b76dd
    Closes-Bug: #1495343

Changed in congress:
status: In Progress → Fix Committed
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → liberty-rc2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.