congress

Datasource deletion does not stop datasources

Bug #1493430 reported by Tim Hinrichs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
congress
Fix Released
High
Tim Hinrichs
congress liberty-rc2

Bug Description

After deleting datasources, they appear to continue polling. Not all of them. Keystone, and a second nova instance, and the fake datasource driver. They do get deleted from the database, but it seems they did not get removed from d6cage.

See original description
Tags: liberty-rc
Tim Hinrichs (thinrichs)
description: updated
Revision history for this message
Tim Hinrichs (thinrichs) wrote :

Same behavior with both keystone and nova, after restarting congress. Seems something has an extra reference to the datasource drivers.

Changed in congress:
status: New → Confirmed
Tim Hinrichs (thinrichs)
Changed in congress:
status: Confirmed → Triaged
Revision history for this message
Tim Hinrichs (thinrichs) wrote :

It looks like the poller_greenthread has a reference to the object it's polling. So if we delete that greenthread before deleting the object, the object gets garbage collected properly.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/221466

Changed in congress:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to congress (master)

Reviewed: https://review.openstack.org/221466
Committed: https://git.openstack.org/cgit/openstack/congress/commit/?id=abd15fa36a13f5b95180f678bf2c2966557e2bd8
Submitter: Jenkins
Branch: master

commit abd15fa36a13f5b95180f678bf2c2966557e2bd8
Author: Tim Hinrichs <email address hidden>
Date: Tue Sep 8 11:30:17 2015 -0700

    Ensure datasources are properly deleted

    Previously, deleting a datasource driver did not remove it from the DSE.
    That was caused by the polling thread having a reference to the object
    it was polling and therefore the object was not properly garbage
    collected upon deletion.

    This change deletes the polling thread and then deletes the object,
    which allows garbage collection to properly eliminate the datasource.

    Change-Id: I8063dab0786e7c728ba0c0c9b3cc33748f70a38c
    Closes-bug: 1493430

Changed in congress:
status: In Progress → Fix Committed
Tim Hinrichs (thinrichs)
Changed in congress:
milestone: none → liberty-rc2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.