Ubuntu Music App

Support m4a cover art

Bug #1492407 reported by TenLeftFingers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Alejandro J. Cura
Canonical System Image ww46-2015 "ota8"
Thumbnailer
Fix Released
Medium
Michi Henning
Ubuntu Music App
Invalid
Undecided
Unassigned
mediascanner2 (Ubuntu)
Fix Released
Undecided
James Henstridge

Bug Description

An album I downloaded from 7digital does not display album art for the m4a version, but does for the mp3 version. m4a art displays fine in the file manager on the desktop (win / Ubuntu).

I've tried other m4a in my collection and get the same result.

Related branches

lp://staging/~jamesh/mediascanner2/m4a-coverart
PS Jenkins bot (community): Approve (continuous-integration)
Mediascanner Team: Pending requested
Diff: 135 lines (+60/-12)
2 files modified
src/daemon/MetadataExtractor.cc (+12/-1)
test/test_metadataextractor.cc (+48/-11)
lp://staging/~michihenning/thumbnailer/add-preview-image-extraction
James Henstridge: Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 251 lines (+127/-25)
5 files modified
debian/control (+2/-0)
src/thumbnailer.cpp (+1/-1)
src/vs-thumb/thumbnailextractor.cpp (+64/-24)
tests/stress/stress_test.cpp (+16/-0)
tests/vs-thumb/vs-thumb_test.cpp (+44/-0)
Revision history for this message
Victor Thompson (vthompson) wrote :

Hi, the ability to display the cover art for differing files is either a function of the Thumbnailer or possibly the Mediascanner service. I've marked the Thumbnailer service as affected so they can take a look if possible.

Revision history for this message
Michi Henning (michihenning) wrote :

Can you tell us exactly what artist and album you used or, even better, could you attach the media file.

This would help us figure out what's going on.

Thanks,

Michi.

Revision history for this message
TenLeftFingers (tenleftfingers) wrote :

Apologies, my email reply didn't make it to launchpad it seems. Maybe because of the attachments.

I'll attach two files. One from The Art of Mindful Living by Thich Nhat Hanh (don't remember where I got that one) and Space Trix, Vol. ' by Various Artists (purchased from 7 Digital using the scope on a BQ E4.5).

Thanks guys,
Jarlath

Revision history for this message
TenLeftFingers (tenleftfingers) wrote :
Revision history for this message
TenLeftFingers (tenleftfingers) wrote :
Revision history for this message
James Henstridge (jamesh) wrote :

So, running gst-discoverer-1.0 over one of your files, I get:

  Tags:
      ...
      preview image: buffer of 86005 bytes, type: image/png

In contrast, one of my MP3s with cover art

  Tags:
      ...
      image: buffer of 190244 bytes, type: image/jpeg, width=(int)800, height=(int)800, sof-marker=(int)0

So it looks like the image is exposed as GST_TAG_PREVIEW_IMAGE instead of GST_TAG_IMAGE via GStreamer.

To fix this, I'll need to (a) update mediascanner2 to check for both tags when deciding whether a file contains embedded art, and (b) update thumbnailer to extract from the preview image tag too.

Michi Henning (michihenning)
Changed in thumbnailer:
assignee: nobody → Michi Henning (michihenning)
importance: Undecided → Medium
Revision history for this message
Michi Henning (michihenning) wrote :

We have a fix for the thumbnailer, which now correctly deals with the breathing m4a.

Changed in music-app:
status: New → Invalid
Changed in mediascanner2:
assignee: nobody → James Henstridge (jamesh)
Michi Henning (michihenning)
Changed in thumbnailer:
status: New → In Progress
Michi Henning (michihenning)
Changed in thumbnailer:
status: In Progress → Fix Committed
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
milestone: none → ww46-2015
importance: Undecided → Medium
status: New → In Progress
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Alejandro J. Cura (alecu)
Changed in canonical-devices-system-image:
assignee: nobody → Alejandro J. Cura (alecu)
Michi Henning (michihenning)
Changed in thumbnailer:
status: Fix Committed → Fix Released
James Henstridge (jamesh)
affects: mediascanner2 → mediascanner2 (Ubuntu)
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
James Henstridge (jamesh)
Changed in mediascanner2 (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.