Manually skipping a job should require entering a comment
Bug #1490610 reported by
Ara Pulido
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox Converged |
Fix Released
|
Medium
|
Maciej Kisielewski | ||
Bug Description
In checkbox-gui, when a user tries to manually skip a job they need to provide a comment.
This is very useful to understand why some jobs were skipped. It makes cert reviewing easier and it can show bugs in the resource jobs.
We need this implemented in checkbox-converged to get to feature parity.
Related branches
lp://staging/~kissiel/checkbox/fix-1490610-add-comment-when-skipping
- Sylvain Pineau (community): Approve
-
Diff: 65 lines (+19/-2)3 files modifiedcheckbox-touch/components/CommentsDialog.qml (+2/-0)
checkbox-touch/components/actions/SkipAction.qml (+10/-2)
checkbox-touch/tests/autopilot/checkbox_touch/test_checkbox_touch.py (+7/-0)
| Changed in checkbox-converged: | |
| importance: | Undecided → Medium |
| milestone: | none → 1.2.3 |
| assignee: | nobody → Maciej Kisielewski (kissiel) |
| status: | New → In Progress |
| Changed in checkbox-converged: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox-converged: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
