Mir

On Wily/mesa-kms starting a server with a "test client" crashes the server

Bug #1489806 reported by Alan Griffiths
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alexandros Frantzis
Mir 0.16.0
mir (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

$ sudo bin/mir_demo_server --display-config sidebyside --test-client bin/mir_demo_client_basic

Expect: the server to start (and the client to connect then exit immediately)

Actual: server crashes

ERROR: /home/alan/display_server/mir1/src/common/fatal/fatal.cpp(55): Throw in function void mir::fatal_error_except(const char*, ...)
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::runtime_error> >
std::exception::what: Failed to schedule page flip

Note this may be related to lp:1489689 which notes similar symptoms starting at the same time.

I see the problem with both trunk and 0.14 (not with mesa-x11, not with vivid)

Related branches

lp://staging/~afrantzis/mir/fix-1489806-test-client
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Kevin DuBois (community): Approve
Andreas Pokorny (community): Approve
Diff: 15 lines (+3/-2)
1 file modified
examples/server_example_test_client.cpp (+3/-2)
lp://staging/mir
PS Jenkins bot (community): Approve (continuous-integration)
Alan Griffiths: Approve
Kevin DuBois (community): Approve
Diff: 1373 lines (+579/-161)
23 files modified
3rd_party/android-input/android/frameworks/base/services/input/MirLog.cpp (+157/-5)
include/test/mir_test_framework/display_server_test_fixture.h (+2/-0)
include/test/mir_test_framework/stub_client_connection_configuration.h (+35/-0)
include/test/mir_test_framework/testing_client_configuration.h (+43/-0)
include/test/mir_test_framework/testing_process_manager.h (+7/-8)
src/client/mir_client_library.cpp (+39/-17)
src/server/graphics/android/hwc_common_device.cpp (+15/-13)
src/server/options/program_option.cpp (+2/-1)
tests/acceptance-tests/test_client_authorization.cpp (+7/-0)
tests/acceptance-tests/test_client_focus_notification.cpp (+2/-9)
tests/acceptance-tests/test_client_input.cpp (+8/-15)
tests/acceptance-tests/test_client_library.cpp (+30/-17)
tests/acceptance-tests/test_focus_selection.cpp (+2/-9)
tests/acceptance-tests/test_server_shutdown.cpp (+2/-9)
tests/acceptance-tests/test_shell_control_of_surface_configuration.cpp (+2/-9)
tests/acceptance-tests/test_surfaceloop.cpp (+3/-10)
tests/acceptance-tests/test_surfaces_with_output_id.cpp (+2/-9)
tests/mir_test_framework/CMakeLists.txt (+1/-0)
tests/mir_test_framework/display_server_test_fixture.cpp (+9/-6)
tests/mir_test_framework/testing_client_options.cpp (+126/-0)
tests/mir_test_framework/testing_process_manager.cpp (+41/-1)
tests/unit-tests/graphics/android/test_hwc_device.cpp (+25/-1)
tests/unit-tests/logging/test_legacy_input_report.cpp (+19/-22)
lp://staging/ubuntu/wily-proposed/mir
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

More information:

--- src/platforms/mesa/server/kms/kms_page_flipper.cpp 2015-07-23 02:39:20 +0000
+++ src/platforms/mesa/server/kms/kms_page_flipper.cpp 2015-08-28 10:42:02 +0000
@@ -65,7 +65,10 @@
                                &pending_page_flips[crtc_id]);

     if (ret)
+ {
+ printf("DEBUG cannot flip CRTC for connector %u (%d): %m\n", crtc_id, errno);
         pending_page_flips.erase(crtc_id);
+ }

     return (ret == 0);
 }

~~~~

DEBUG cannot flip CRTC for connector 24 (13): Permission denied
DEBUG: Dying, outputs=1
DEBUG cannot flip CRTC for connector 20 (13): Permission denied
DEBUG: Dying, outputs=1
ERROR: /home/alan/display_server/mir1/src/common/fatal/fatal.cpp(55): Throw in function void mir::fatal_error_except(const char*, ...)
Dynamic exception type: boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::runtime_error> >
std::exception::what: Failed to schedule page flip

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

The same happens here i915/i965 the same command with --launch-client works though.

Alexandros Frantzis (afrantzis)
Changed in mir:
status: New → Confirmed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

We could dance around page flip scheduling and only do it when we think it's safe, but that's not a reliable solution and I suspect we already do that.

If we find there are still realistic ways of causing this error that are not themselves Mir bugs then we need to treat it as a warning only (one that does not repeat and flood the log).

Alexandros Frantzis (afrantzis)
Changed in mir:
assignee: nobody → Alexandros Frantzis (afrantzis)
status: Confirmed → In Progress
Alexandros Frantzis (afrantzis)
Changed in mir:
importance: Undecided → Medium
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.16.0
Daniel van Vugt (vanvugt)
Changed in mir:
status: In Progress → Fix Committed
Cemil Azizoglu (cemil-azizoglu)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

mir (0.16.0+15.10.20150921.1-0ubuntu1) wily; urgency=medium

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.