Ceilometer

notifications won't be requeued when event handling error

Bug #1489431 reported by Liusheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Undecided
Liusheng
Ceilometer 5.0.0 "liberty"

Bug Description

In ceilometer EventsNotificationEndpoint, if we didn't enable configured ack_on_event_error option, we expect the notification message will be requeued when handling error. see[1]. the messaging driver will handle two result oslo_messaging.NotificationResult.REQUEUE and oslo_messaging.NotificationResult.HANDLED to perform requeue or ack, see[2].
But in ceilometer the two result won't be returned, because the info() and error() method in EventsNotificationEndpoint will just return None.

[1] https://github.com/openstack/ceilometer/blob/master/ceilometer/event/endpoint.py#L78-L80

[2] https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/dispatcher.py#L133-L138

See original description
Liusheng (liusheng)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217677

Changed in ceilometer:
assignee: nobody → Liusheng (liusheng)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/217677
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=c197f4793d3f2cb6ed37f6b8fe25a9e849665397
Submitter: Jenkins
Branch: master

commit c197f4793d3f2cb6ed37f6b8fe25a9e849665397
Author: liu-sheng <email address hidden>
Date: Thu Aug 27 19:54:42 2015 +0800

    Fix requeue process on event handling error

    The NotificationDispatcher in oslo_messaging is able to requeue
    notifications which cannot be successfully handled by endpoint. That need
    endpoint return a 'requeue' if exception happened on handling. In
    EventsNotificationEndpoint of ceilometer, the return value was always
    None.

    Change-Id: Iab10ca06766e1454d1d2338e72087b6bca7590b6
    Closes-Bug: #1489431

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.