[dashboard] use is_superuser instead of has_perm('openstack.roles.admin')

Bug #1489035 reported by zhurong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
zhurong

Bug Description

horizon and openstack can have arbitrary admin roles. We should check is_superuser, that inspects OPENSTACK_KEYSTONE_ADMIN_ROLES instead of hardcoding admin permission role

zhurong (zhu-rong)
Changed in murano:
assignee: nobody → zhu.rong (zhu-rong)
summary: - [dashboard]change role admin to use is_superuser
+ [dashboard] use is_superuser instead of
+ has_perm('openstack.roles.admin')
Changed in murano:
importance: Undecided → Medium
milestone: none → liberty-3
status: New → Triaged
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/217515

Changed in murano:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/217515
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=6d0b862b66fa7909f3fa11fe7baab1c71f372c7c
Submitter: Jenkins
Branch: master

commit 6d0b862b66fa7909f3fa11fe7baab1c71f372c7c
Author: zhu.rong <zhu.rong@99cloud.net>
Date: Thu Aug 27 12:43:40 2015 +0800

    Use is_superuser instead of hardcode admin role

    horizon and openstack can have arbitrary admin roles. We should check
    is_superuser, that inspects OPENSTACK_KEYSTONE_ADMIN_ROLES instead of
    hardcoding admin permission role.

    Change-Id: Ibd13ae2c1e3a60fea8a44dcb258e39e3a7fc6d3a
    Closes-Bug: #1489035

Changed in murano:
status: In Progress → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: liberty-3 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.