system logging module is still in use in many places

Bug #1481370 reported by Sergey Vilgelm
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Sergey Vilgelm
OpenStack DBaaS (Trove)
Fix Released
Medium
Sergey Vilgelm
Stackalytics
Fix Released
Undecided
Sergey Vilgelm
neutron
Fix Released
Undecided
Sergey Vilgelm
tempest
Fix Released
Undecided
Sergey Vilgelm
tuskar
Won't Fix
Low
Sergey Vilgelm

Bug Description

The system logging module is still in use in many places, i suggest to use the oslo.log library. Form the 1.8 version of oslo.log we can use the constants of the log levels (INFO, DEBUG, etc) directly from log module instead of system logging module.

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209115

Changed in trove:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Changed in trove:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/209115
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=c62bf2f34b3266357d05b95feda4cea9da933628
Submitter: Jenkins
Branch: master

commit c62bf2f34b3266357d05b95feda4cea9da933628
Author: Sergey Vilgelm <email address hidden>
Date: Tue Aug 4 17:29:20 2015 +0300

    Use oslo.log library instead of system logging module

    The constants of log levels were added in the 1.8 version of
    the oslo.log library. So we can replace all usage of system
    logging module with log module from oslo.log.
    Use WritableLogger class from the loggers module of the oslo.log
    library.

    Change-Id: Ic93e25a9ca3a288cdfcdb75fbe40a7d1ba2a23c9
    Closes-Bug: 1481370

Changed in trove:
status: In Progress → Fix Committed
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :
Changed in tuskar:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Changed in murano:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209477

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209601

Changed in tempest:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/209477
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=d6f9fbeb2fcc65a8ee320307d1b2ad021fbf72e2
Submitter: Jenkins
Branch: master

commit d6f9fbeb2fcc65a8ee320307d1b2ad021fbf72e2
Author: Sergey Vilgelm <email address hidden>
Date: Wed Aug 5 13:21:09 2015 +0300

    Use oslo.log library instead of system logging module

    The constants of log levels were added in the 1.8 version of
    the oslo.log library. So we can replace most uses of system
    logging module with log module from oslo.log.

    Change-Id: I36d36c7ed1246de7ba0d0cc8fd1ffcc4dfbcba25
    Closes-Bug: 1481370

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :
Changed in stackalytics:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stackalytics (master)

Reviewed: https://review.openstack.org/209667
Committed: https://git.openstack.org/cgit/stackforge/stackalytics/commit/?id=28d4d7d544718a237c0a60bb37f791a9a2a6ef8d
Submitter: Jenkins
Branch: master

commit 28d4d7d544718a237c0a60bb37f791a9a2a6ef8d
Author: Sergey Vilgelm <email address hidden>
Date: Wed Aug 5 23:05:38 2015 +0300

    Use oslo.log instead of system logging

    Use the logging.DEBUG constant from oslo_log.log module.

    Change-Id: Ie5992e2465d625f1b49c06ee4077d93ce73538b7
    Closes-Bug: 1481370

Changed in stackalytics:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-agent (master)

Reviewed: https://review.openstack.org/208131
Committed: https://git.openstack.org/cgit/openstack/murano-agent/commit/?id=55f94816eacfe2dc2b70bff5936aea26ad55eeb8
Submitter: Jenkins
Branch: master

commit 55f94816eacfe2dc2b70bff5936aea26ad55eeb8
Author: Sergey Vilgelm <email address hidden>
Date: Sat Aug 1 09:26:35 2015 +0300

    Switch to the oslo.log library

    Use oslo.log instead of oslo-incubator.
    Use oslo.log instead of system logging.
    Add oslo.log to the requirements.txt.
    Remove unused oslo-incubator modules.

    Implements: blueprint port-oslo-incubator-to-oslo-log

    Partial-Bug: 1481370
    Change-Id: I7047497f2022b0c56be0f3811f1bb59ffe470877

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron-lbaas (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/211150

Revision history for this message
Sergey Vilgelm (sergey.vilgelm) wrote :
Changed in neutron:
assignee: nobody → Sergey Vilgelm (sergey.vilgelm)
status: New → In Progress
Ben Nemec (bnemec)
Changed in tuskar:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-lbaas (master)

Reviewed: https://review.openstack.org/211150
Committed: https://git.openstack.org/cgit/openstack/neutron-lbaas/commit/?id=9aa4f1f42b6c1084cb047a852c7411367becee7f
Submitter: Jenkins
Branch: master

commit 9aa4f1f42b6c1084cb047a852c7411367becee7f
Author: Sergey Vilgelm <email address hidden>
Date: Mon Aug 10 15:52:45 2015 +0300

    Use oslo.log library instead of system logging module

    The constants of log levels were added in the 1.8 version of
    the oslo.log library. So we can replace all usage of system
    logging module with log module from oslo.log.

    Change-Id: I2992df0bec6337aefa8a75d4853b132bd134fa42
    Related-Bug: 1481370

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/211429

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/211429
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5ff3439df5942a9cb150ac4cd3da987e20a31f5c
Submitter: Jenkins
Branch: master

commit 5ff3439df5942a9cb150ac4cd3da987e20a31f5c
Author: Sergey Vilgelm <email address hidden>
Date: Mon Aug 10 15:46:27 2015 +0300

    Use oslo.log library instead of system logging module

    The constants of log levels were added in the 1.8 version of
    the oslo.log library. So we can replace all usage of system
    logging module with log module from oslo.log.

    Change-Id: I2992df0bec6337aefa8a75d4853b132bd134fa42
    Closes-Bug: 1481370

Changed in neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron-vpnaas (master)

Reviewed: https://review.openstack.org/211136
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=5ca88612849c4254f2852f0fc3383b6e38c42f6f
Submitter: Jenkins
Branch: master

commit 5ca88612849c4254f2852f0fc3383b6e38c42f6f
Author: Sergey Vilgelm <email address hidden>
Date: Mon Aug 10 15:57:06 2015 +0300

    Use oslo.log library instead of system logging module

    Use the log module form oslo_log library instead of the system
    logging module for the service.vpn.plugin module.

    Change-Id: Ib0de7e53f38d06b7909adb63057647211d76902c
    Related-Bug: 1481370

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (feature/pecan)

Fix proposed to branch: feature/pecan
Review: https://review.openstack.org/218710

Changed in trove:
milestone: none → liberty-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (feature/pecan)
Download full text (155.6 KiB)

Reviewed: https://review.openstack.org/218710
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2c5f44e1b3bd4ed8a0b7232fd293b576cc8c1c87
Submitter: Jenkins
Branch: feature/pecan

commit f35d1c5c50dccbef1a2e079f967b82f0df0e22e9
Author: Adelina Tuvenie <email address hidden>
Date: Thu Aug 27 02:27:28 2015 -0700

    Fixes wrong neutron Hyper-V Agent name in constants

    Change Id03fb147e11541be309c1cd22ce27e70fadc28b5 moved the
    AGENT_TYPE_HYPERV constant from common.constants to
    plugins.ml2.drivers.hyperv.constants but change the value of the
    constant from 'HyperV agent' to 'hyperv'. This patch changes
    the name back to 'HyperV agent'

    Change-Id: If74b4b2a84811e266c8b12e70bf6bfe74ed4ea21
    Partial-Bug: #1487598

commit de604de334854e2eb6b4312ff57920564cbd4459
Author: OpenStack Proposal Bot <email address hidden>
Date: Sun Aug 30 01:39:06 2015 +0000

    Updated from global requirements

    Change-Id: Ie52aa3b59784722806726e4046bd07f4a4d97328

commit f0415ac20eaf5ab4abb9bd4839bf6d04ceee85d0
Author: armando-migliaccio <email address hidden>
Date: Fri Aug 28 13:53:04 2015 -0700

    Revert "Add support for unaddressed port"

    This implementation may expose a vulnerability where a malicious
    user can sieze the opportunity of a time window where a port
    may land unaddressed on a shared network, thus allowing him/her
    to suck up all the tenant traffic he/she wants....oh the shivers.

    This reverts commit d4c52b7f5a36a103a92bf9dcda7f371959112292.

    Change-Id: I7ebdaa8d3defa80eab90e460fde541a5bdd8864c

commit 013fdcd2a6d45dbe4de5d6e7077e5e9b60985ef9
Author: Assaf Muller <email address hidden>
Date: Fri Aug 28 16:41:07 2015 -0400

    Improve logging upon failure in iptables functional tests

    This will help us nail down a more accurate and efficient logstash
    query.

    Change-Id: Iee4238e358f7b056e373c7be8d6aa3202117a680
    Related-Bug: #1478847

commit 622dea818d851224a43d5276a81d5ce8a6eebb76
Author: Ivar Lazzaro <email address hidden>
Date: Mon Aug 17 17:17:42 2015 -0700

    handle gw_info outside of the db transaction on router creation

    Move the gateway interface creation outside the DB transaction
    to avoid lock timeout.

    Change-Id: I5a78d7f32e8ca912016978105221d5f34618af19
    Closes-bug: 1485809

commit 5b27d290a0a95f6247fc5a0fe6da1e7d905e6b2d
Author: Assaf Muller <email address hidden>
Date: Wed Aug 26 10:07:03 2015 -0400

    Remove ml2 resource extension success logging

    This is the cause of a tremendous amount of logs, for no
    perceivable gain. A normal dvr run in the gate shows this debug
    message around 120K times, which is way too much.

    Closes-Bug: #1489952

    Change-Id: I26fca8515d866a7cc1638d07fa33bc04479ae221

commit 8d3faf549cba2f58c872ef4121b2481e73464010
Author: huangpengtao <email address hidden>
Date: Fri Aug 28 23:20:46 2015 +0800

    Replace "prt" variable by "port"

    the local variable prt is meaningless,
    and port is used popular.

    Change-Id: I20849102cf5b4d84433c46791b4b1e2a22dc4739

commit ee374e7a5f4dea538fcd942f5...

tags: added: in-feature-pecan
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Changed in trove:
status: Fix Committed → Fix Released
Ilya Shakhat (shakhat)
Changed in stackalytics:
milestone: none → 0.9
status: Fix Committed → Fix Released
Changed in murano:
importance: Undecided → Medium
milestone: none → liberty-3
Changed in murano:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: liberty-3 → 4.0.0
Thierry Carrez (ttx)
Changed in neutron:
milestone: liberty-3 → 7.0.0
Changed in murano:
milestone: liberty-3 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tuskar (master)

Change abandoned by Dougal Matthews (<email address hidden>) on branch: master
Review: https://review.openstack.org/205391
Reason: Abandoning changes against the retired repo.

Dougal Matthews (d0ugal)
Changed in tuskar:
status: In Progress → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tempest (master)

Change abandoned by Sergey Vilgelm (<email address hidden>) on branch: master
Review: https://review.openstack.org/209601

Changed in tempest:
status: In Progress → Confirmed
Revision history for this message
Ken'ichi Ohmichi (oomichi) wrote :

This has been fixed on Tempest side since https://review.openstack.org/#/c/398019/

Changed in tempest:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.