intermittent hmac test failure

Bug #1481149 reported by gordon chung
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceilometer
Fix Released
Low
gordon chung

Bug Description

this happens occasionally in gate and occasionally on my dev machine

======================================================================
FAIL: ceilometer.tests.test_notification.TestRealNotificationHA.test_notification_service_no_secret
tags: worker-2
----------------------------------------------------------------------
Empty attachments:
  stderr
  stdout

Traceback (most recent call last):
  File "/opt/stack/ceilometer/.tox/py-mysql/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
    return func(*args, **keywargs)
  File "ceilometer/tests/test_notification.py", line 395, in test_notification_service_no_secret
    self.assertFalse(fake_hmac.called)
  File "/opt/stack/ceilometer/.tox/py-mysql/lib/python2.7/site-packages/unittest2/case.py", line 696, in assertFalse
    raise self.failureException(msg)
AssertionError: True is not false

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/208783

Changed in ceilometer:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ceilometer (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/208994

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ceilometer (master)

Change abandoned by Mehdi Abaakouk (sileht) (<email address hidden>) on branch: master
Review: https://review.openstack.org/208994
Reason: Go for https://review.openstack.org/#/c/208783

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ceilometer (master)

Reviewed: https://review.openstack.org/208783
Committed: https://git.openstack.org/cgit/openstack/ceilometer/commit/?id=12695cf4aeac5fe93450ce77597bf0d5322095b9
Submitter: Jenkins
Branch: master

commit 12695cf4aeac5fe93450ce77597bf0d5322095b9
Author: gordon chung <email address hidden>
Date: Mon Aug 3 23:56:11 2015 -0400

    minimise scope of hmac mocking

    we minimise it by deleting the test. the method itself is tested
    to ensure empty secret is processed accordingly so the
    coverage is already there.

    Change-Id: I9a3f2530cfbeb1e3a6f768da2c098f9cca92b20b
    Closes-Bug: #1481149

Changed in ceilometer:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ceilometer:
milestone: liberty-3 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.