widelands

Building description hidden by other buildings

Bug #1480927 reported by Kyromaster
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
widelands
Won't Fix
Undecided
Unassigned
widelands build21-rc1

Bug Description

Sometimes the description of a building is hidden by other buildings.
Attached is a savegame where you can see this with the building left of the headquarters.

Tags: graphics ui

Related branches

lp://staging/~widelands-dev/widelands/bug-1480927-building-texts
Klaus Halfmann: Approve
Diff: 1019 lines (+170/-219)
33 files modified
src/economy/flag.h (+0/-2)
src/economy/portdock.cc (+1/-1)
src/economy/portdock.h (+0/-1)
src/economy/road.h (+0/-1)
src/editor/editorinteractive.cc (+3/-2)
src/graphic/game_renderer.h (+0/-1)
src/logic/CMakeLists.txt (+0/-2)
src/logic/map_objects/bob.cc (+0/-1)
src/logic/map_objects/bob.h (+0/-2)
src/logic/map_objects/draw_text.h (+0/-33)
src/logic/map_objects/immovable.cc (+29/-13)
src/logic/map_objects/immovable.h (+3/-5)
src/logic/map_objects/map_object.cc (+4/-35)
src/logic/map_objects/map_object.h (+6/-10)
src/logic/map_objects/tribes/building.cc (+4/-23)
src/logic/map_objects/tribes/building.h (+1/-6)
src/logic/map_objects/tribes/constructionsite.cc (+0/-4)
src/logic/map_objects/tribes/constructionsite.h (+0/-1)
src/logic/map_objects/tribes/dismantlesite.cc (+0/-4)
src/logic/map_objects/tribes/dismantlesite.h (+0/-1)
src/logic/map_objects/tribes/ship.cc (+19/-20)
src/logic/map_objects/tribes/ship.h (+1/-7)
src/logic/map_objects/tribes/soldier.cc (+0/-1)
src/logic/map_objects/tribes/soldier.h (+0/-1)
src/logic/map_objects/tribes/worker.cc (+0/-1)
src/logic/map_objects/tribes/worker.h (+0/-1)
src/wui/interactive_base.cc (+1/-1)
src/wui/interactive_base.h (+10/-0)
src/wui/interactive_gamebase.cc (+54/-0)
src/wui/interactive_gamebase.h (+2/-0)
src/wui/interactive_player.cc (+22/-35)
src/wui/interactive_spectator.cc (+9/-2)
src/wui/transport_draw.cc (+1/-2)
Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks for reporting all those bugs :)

I think you forgot the attachment for this one. Could you please also create a screenshot? Thanks :)

Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Thanks for reporting.

This is a known issue which has been discussed some in the past as well. I believe there has been some improvements, but it may not be perfect yet. The problem is also affected by translations since some languages are more verbose or use more letters than others.

There is a bug report with more discussion as well as several suggestions, but I couldn't find it at the moment. :( GunChloec: do you remember this one? I could only find bug 1216523, but that has fewer comments than the one I'm thinking of.

PS. I couldn't find a savegame, but for issues like this a screenshot demonstrating the issue should be good enough. (Especially since the building names will be affected by translations so it might not be reproducible by all)

tags: added: ui
Revision history for this message
GunChleoc (gunchleoc) wrote :

I remember a longer discussion too, but I can't find it either. We should use the narrow font for long building names.

Revision history for this message
Kyromaster (kyromaster) wrote :

Screenshot displaying the bug

Revision history for this message
GunChleoc (gunchleoc) wrote :

Thanks - this is a different bug from the other one. Something's wrong with the zlevel (ordering of things on screen).

If you still have a savegame, could you please attach it? It will be helpful for this bug.

tags: added: graphic
GunChleoc (gunchleoc)
Changed in widelands:
status: New → Confirmed
Revision history for this message
Kyromaster (kyromaster) wrote :

Savegame showing the bug

Revision history for this message
GunChleoc (gunchleoc) wrote :

See also https://bugs.launchpad.net/widelands/+bug/839386

GunChleoc (gunchleoc)
tags: added: graphics
removed: graphic
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → GunChleoc (gunchleoc)
milestone: none → build20-rc1
Revision history for this message
GunChleoc (gunchleoc) wrote :

Screenshot of the bug: https://launchpadlibrarian.net/213499092/bug.png

Screenshot with fixed bug attached

Revision history for this message
GunChleoc (gunchleoc) wrote :

Before/after screenshot

GunChleoc (gunchleoc)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

The fix is buggy, causing animations to sometimes disappear for frames != 0, so removing the fix for Build 20.

c.f. https://bugs.launchpad.net/widelands/+bug/1796364

Changed in widelands:
status: Fix Committed → Confirmed
milestone: build20-rc1 → build21-rc1
Revision history for this message
GunChleoc (gunchleoc) wrote :

Migrated to https://github.com/widelands/widelands/issues/3039

Changed in widelands:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.