kolla

merge_config.py uses a hash which can clash

Bug #1478494 reported by Sam Yaple
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Wishlist
Sam Yaple
kolla liberty-2 "liberty-2"

Bug Description

Originally the way the comparision was done there was a string compare and hashing served a slightly different purpose. Now it is probably less effecient to do the hashing than to just do a safe filecmp.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.openstack.org/205990

Changed in kolla:
status: Triaged → In Progress
Sam Yaple (s8m)
Changed in kolla:
milestone: none → liberty-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/205990
Committed: https://git.openstack.org/cgit/stackforge/kolla/commit/?id=53c0ada479815ef019e2a79bcf9e85d66810bb3a
Submitter: Jenkins
Branch: master

commit 53c0ada479815ef019e2a79bcf9e85d66810bb3a
Author: Sam Yaple <email address hidden>
Date: Mon Jul 27 10:06:55 2015 +0000

    Removes hashing from merge_configs.py

    There is no benefit to hashing in merge_configs.py In fact, the opposite
    is true, hashes can collide. This does a direct compare rather than hash.

    Change-Id: I9ab7af13e813e2267984092027daf1658faf5bf3
    Closes-Bug: #1478494

Changed in kolla:
status: In Progress → Fix Committed
Sam Yaple (s8m)
Changed in kolla:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.