[dashboard] too loose regex for murano/categories/add url

Bug #1476991 reported by Lin Yang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Lin Yang

Bug Description

How to reproduce:
Input a mistake url http://{horizon}/murano/categories/addabcd into browser, it shows the view of adding category instead of 404 as expect.

Root cause:
The current url regex '^add' is too loose, which will match all url start with 'add'.
https://git.openstack.org/cgit/openstack/murano-dashboard/tree/muranodashboard/categories/urls.py#n24

Lin Yang (lin-a-yang)
Changed in murano:
assignee: nobody → Lin Yang (lin-a-yang)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/204486

Changed in murano:
status: New → In Progress
Changed in murano:
importance: Undecided → Medium
milestone: none → liberty-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/204486
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=a98d91cb5d10df5224108a005320b265d9fb6a76
Submitter: Jenkins
Branch: master

commit a98d91cb5d10df5224108a005320b265d9fb6a76
Author: Lin Yang <email address hidden>
Date: Wed Jul 22 16:12:27 2015 +0800

    Fix too loose url regex for murano/categories/add

    Current url regex '^add' will match all urls start with 'add' by mistake. The
    '$' added will make sure the regex only match 'add' as expect.

    Change-Id: I0611cbe76b6614f7aa694124767c6caaccfb5890
    Closes-Bug: #1476991

Changed in murano:
status: In Progress → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: liberty-2 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.