Ubuntu
webbrowser-app package

Taps at the bottom of the screen trigger a bottom edge gesture

Bug #1474533 reported by taiebot65
56
This bug affects 17 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
Canonical System Image 11 "OTA11"
webbrowser-app (Ubuntu)
Fix Released
High
Olivier Tilloy

Bug Description

It is too easy to trigger a bottom edge action when using the video timeline in landscape mode.

It’s also almost impossible to tap a link at the very bottom of a page without triggering the bottom edge gesture.

See original description
Tags: video

Related branches

lp://staging/~osomon/webbrowser-app/use-uitk-swipearea
system-apps-ci-bot: Needs Fixing (continuous-integration)
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 4899 lines (+8/-4580)
46 files modified
CMakeLists.txt (+0/-1)
debian/control (+0/-1)
src/app/CMakeLists.txt (+1/-3)
src/app/browserapplication.cpp (+0/-10)
src/app/unity8/CMakeLists.txt (+0/-1)
src/app/unity8/README (+0/-8)
src/app/unity8/libs/CMakeLists.txt (+0/-1)
src/app/unity8/libs/UbuntuGestures/CMakeLists.txt (+0/-36)
src/app/unity8/libs/UbuntuGestures/CandidateInactivityTimer.cpp (+0/-41)
src/app/unity8/libs/UbuntuGestures/CandidateInactivityTimer.h (+0/-49)
src/app/unity8/libs/UbuntuGestures/DebugHelpers.cpp (+0/-95)
src/app/unity8/libs/UbuntuGestures/DebugHelpers.h (+0/-31)
src/app/unity8/libs/UbuntuGestures/Pool.h (+0/-132)
src/app/unity8/libs/UbuntuGestures/Timer.cpp (+0/-109)
src/app/unity8/libs/UbuntuGestures/Timer.h (+0/-105)
src/app/unity8/libs/UbuntuGestures/TouchOwnershipEvent.cpp (+0/-35)
src/app/unity8/libs/UbuntuGestures/TouchOwnershipEvent.h (+0/-50)
src/app/unity8/libs/UbuntuGestures/TouchRegistry.cpp (+0/-500)
src/app/unity8/libs/UbuntuGestures/TouchRegistry.h (+0/-182)
src/app/unity8/libs/UbuntuGestures/UbuntuGesturesGlobal.h (+0/-23)
src/app/unity8/libs/UbuntuGestures/UnownedTouchEvent.cpp (+0/-39)
src/app/unity8/libs/UbuntuGestures/UnownedTouchEvent.h (+0/-45)
src/app/unity8/plugins/CMakeLists.txt (+0/-1)
src/app/unity8/plugins/Ubuntu/CMakeLists.txt (+0/-1)
src/app/unity8/plugins/Ubuntu/Gestures/AxisVelocityCalculator.cpp (+0/-149)
src/app/unity8/plugins/Ubuntu/Gestures/AxisVelocityCalculator.h (+0/-146)
src/app/unity8/plugins/Ubuntu/Gestures/CMakeLists.txt (+0/-40)
src/app/unity8/plugins/Ubuntu/Gestures/Damper.h (+0/-87)
src/app/unity8/plugins/Ubuntu/Gestures/Direction.cpp (+0/-36)
src/app/unity8/plugins/Ubuntu/Gestures/Direction.h (+0/-45)
src/app/unity8/plugins/Ubuntu/Gestures/DirectionalDragArea.cpp (+0/-886)
src/app/unity8/plugins/Ubuntu/Gestures/DirectionalDragArea.h (+0/-308)
src/app/unity8/plugins/Ubuntu/Gestures/Gestures.qmltypes (+0/-168)
src/app/unity8/plugins/Ubuntu/Gestures/PressedOutsideNotifier.cpp (+0/-119)
src/app/unity8/plugins/Ubuntu/Gestures/PressedOutsideNotifier.h (+0/-62)
src/app/unity8/plugins/Ubuntu/Gestures/TimeSource.cpp (+0/-49)
src/app/unity8/plugins/Ubuntu/Gestures/TimeSource.h (+0/-54)
src/app/unity8/plugins/Ubuntu/Gestures/TouchDispatcher.cpp (+0/-367)
src/app/unity8/plugins/Ubuntu/Gestures/TouchDispatcher.h (+0/-89)
src/app/unity8/plugins/Ubuntu/Gestures/TouchGate.cpp (+0/-253)
src/app/unity8/plugins/Ubuntu/Gestures/TouchGate.h (+0/-112)
src/app/unity8/plugins/Ubuntu/Gestures/UbuntuGesturesQmlGlobal.h (+0/-23)
src/app/unity8/plugins/Ubuntu/Gestures/plugin.cpp (+0/-39)
src/app/unity8/plugins/Ubuntu/Gestures/plugin.h (+0/-31)
src/app/unity8/plugins/Ubuntu/Gestures/qmldir (+0/-3)
src/app/webbrowser/BottomEdgeHandle.qml (+7/-15)
taiebot65 (dedreuil)
description: updated
Revision history for this message
Olivier Tilloy (osomon) wrote :

Which video timeline? I tried both youtube and vimeo on two devices (arale and krillin), and I didn’t have issues seeking in the video without triggering a bottom edge swipe (I did trigger one once in many tests).

Changed in webbrowser-app (Ubuntu):
status: New → Incomplete
Revision history for this message
taiebot65 (dedreuil) wrote :

mm i kind of disagree it happens to me everytime if you rotate in landscape mode and move to the place see attached the screenshot of a youtube video with bottom edge and look how the bottom edge area overlaps the video timeline if you hit the timeline in this area it will trigger a bottom edge action.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Well the bottom edge hint disappears after a couple of seconds when going fullscreen. It’s only a hint, it doesn’t mean that the actual physical place it occupies swallows all touch events. In fact only real swipe gestures from the edge are detected, other events (such as taps) go through to the webview.

Revision history for this message
Dario Cavedon (dcavedon) wrote :

I think this could be a duplicate of bug #1483548.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for catching that Dario. I marked the other one a duplicate of this one, as this one has more information (and was filed earlier).

tags: added: video
Revision history for this message
Olivier Tilloy (osomon) wrote :

Note that currently the bottom edge swipe gesture is the only way to exit fullscreen mode if the website doesn’t provide a UI element to do that (the fullscreen spec doesn’t require pages to provide such a mechanism, so the user agent has to offer a consistent way to escape fullscreen).

I still can’t reliably reproduce the issue on my E4.5: tapping the screen never triggers a bottom edge gesture for me.

Revision history for this message
Olivier Tilloy (osomon) wrote :

Can someone who reliably observes the issue maybe grab a video of their interaction with the device to see what really happens?

Revision history for this message
Michal Predotka (mpredotka) wrote :

Here's the video. Sorry for the quality but I think you can see the issue reproduced: https://youtu.be/zT030l4yYSI

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for webbrowser-app (Ubuntu) because there has been no activity for 60 days.]

Changed in webbrowser-app (Ubuntu):
status: Incomplete → Expired
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: Expired → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
Olivier Tilloy (osomon)
summary: - While full screen videos should disable bottom edge
+ Taps at the bottom of the screen trigger a bottom edge gesture
description: updated
Changed in webbrowser-app (Ubuntu):
importance: Undecided → High
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
assignee: nobody → Olivier Tilloy (osomon)
status: Confirmed → In Progress
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Bill Filler (bfiller)
milestone: none → 11
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20160509.3-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20160509.3-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * Resync trunk.

  [ Olivier Tilloy ]
  * Fine-tune the custom memory-pressure handler, from data gathered on
    several devices. (LP: #1576639)
  * Update translation template.

 -- Olivier Tilloy <email address hidden> Mon, 09 May 2016 17:56:03 +0000

Changed in webbrowser-app (Ubuntu):
status: Fix Committed → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.