Compositor report shows overlays ("bypass") is never used by mir_proving_server on Android, even for fullscreen surfaces
Bug #1474231 reported by
Daniel van Vugt
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Compositor report shows overlays ("bypass") is never used by mir_proving_server on Android, even for fullscreen surfaces.
[1436856634.691034] compositor: Display 0xb0f005a8 averaged 59.717 FPS, 6.574 ms/frame, latency 9.501 ms, 60 frames over 1.004 sec, 0% bypassed
[1436856635.704646] compositor: Display 0xb0f005a8 averaged 58.202 FPS, 6.244 ms/frame, latency 11.579 ms, 59 frames over 1.013 sec, 0% bypassed
[1436856636.705653] compositor: Display 0xb0f005a8 averaged 59.939 FPS, 6.536 ms/frame, latency 11.178 ms, 60 frames over 1.001 sec, 0% bypassed
This does not happen for other demo servers where --compositor-
Related branches
lp://staging/~vanvugt/mir/fix-1474231
- Cemil Azizoglu (community): Approve
- Alexandros Frantzis (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 280 lines (+11/-204)7 files modifiedplayground/demo-shell/demo_compositor.cpp (+11/-3)
playground/demo-shell/demo_renderer.cpp (+0/-28)
playground/demo-shell/demo_renderer.h (+0/-5)
tests/unit-tests/CMakeLists.txt (+0/-1)
tests/unit-tests/examples/CMakeLists.txt (+0/-6)
tests/unit-tests/examples/test_demo_compositor.cpp (+0/-89)
tests/unit-tests/examples/test_demo_renderer.cpp (+0/-72)
Changed in mir: | |
assignee: | nobody → Daniel van Vugt (vanvugt) |
milestone: | none → 0.15.0 |
status: | Triaged → In Progress |
Changed in mir: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
If I recall correctly, this is just DemoRenderer: :would_ embellish( ) not being smart enough to deal with the extra renderable of the software cursor correctly. It should be updated to check the decoration status of each renderable instead.