Fuel for OpenStack

Multiple cluster networks dnsmasq user-defined cobbler template gets lost after containers destruction

Bug #1473483 reported by Vladimir Kuklin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Sergey Yudin
Fuel for OpenStack 7.0
6.1.x
Won't Fix
High
Alexey Stupnikov
Fuel for OpenStack 6.1-updates

Bug Description

6.1 GA

Install master node

Alter config files of cobbler to configure PXE boot of additional node groups.

I.e. edit dnsmasq cobbler template to add additional dhcp range as described here:

https://docs.mirantis.com/openstack/fuel/fuel-6.1/file-ref.html#dnsmasq-template-ref

Destroy containers
Start containers

Expected result:

all the configurations are restored

Actual result:

additional dhcp ranges are lost as cobbler container gets regenerated along with dnsmasq config

Proposed solution - back this data up during container upgrade, convert it into astute.yaml fields and fix fuel library to regenerate these config fields during container bootstrap or even more - link this file into container.

Andrew Woodward (xarses)
tags: added: feature-nodegroup
Revision history for this message
Sergey Yudin (tsipa740) wrote :

Do we really going to support manual modyfication of config files?

Even accroding to the doc
>Note that the dnsmasq.template file is managed by Puppet so all changes are overwritten/removed when the Puppet container is restarted or the Fuel Master node is rebooted.

this is not supported, and, probably, we must implement this via UI or something, instead of manual modyfication.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/209959

Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Sergey Yudin (tsipa740)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/210003

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/209959
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=b59f69257b043212522b3c4fff946bd68068879a
Submitter: Jenkins
Branch: master

commit b59f69257b043212522b3c4fff946bd68068879a
Author: Sergey V. Yudin <email address hidden>
Date: Thu Aug 6 14:32:48 2015 +0000

    Move user-defined extra networks from dnsmasq.template to astute

    Now Multiple Cluster Networks implented by
    manual modification of dnsmasq.template inside container.
    With this approach user-difened networks will be overwritten
    by puppet when docker container will be restarted.
    We going to create astute section EXTRA_ADMIN_NETWORKS
    which will contaion all additional networks used for dhcp.

    For backward compatibility we going to execute script which
    will create this section from dnsmasq.template

    Closes-Bug: #1473483
    Change-Id: I287e717cd6b1c70e62ddcdd09aee421805862d37

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/210003
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=5787af40904d6e209777f936550f06b6930ffb57
Submitter: Jenkins
Branch: master

commit 5787af40904d6e209777f936550f06b6930ffb57
Author: Sergey V. Yudin <email address hidden>
Date: Thu Aug 6 15:59:15 2015 +0000

    Append EXTRA_ADMIN_NETWORKS to dnsmasq.template

    We going to create astute section EXTRA_ADMIN_NETWORKS
    which will contaion all additional networks used for dhcp.
    This needed for Multiple Cluster Networks implementation.

    Depends-On: I287e717cd6b1c70e62ddcdd09aee421805862d37
    Closes-Bug: #1473483
    Change-Id: I3b9a30f3a6bc6468f3088badb261f82b7b7a4fd0

Peter Zhurba (pzhurba)
tags: added: on-verification
Revision history for this message
Peter Zhurba (pzhurba) wrote :

Reproduced on MOS 7.0 ISO #295

Add section

dhcp-range=alpha,10.109.1.68,10.109.1.127,255.255.255.0,120m
dhcp-option=net:alpha,option:router,10.109.1.65
dhcp-boot=net:alpha,pxelinux.0,boothost,10.109.1.2

into dnsmasq.template

dockerctl shell cobbler vi /etc/cobbler/dnsmasq.template

reboot

Section disappears :)

Notes

1 There is cool script for converting dnsmasq.template but it is can be used only during rpm upgrade
2 There is support for additional parameters extra_admin_net but there is no reference or example in

https://docs.mirantis.com/openstack/fuel/fuel-master/file-ref.html#dnsmasq-template-ref
and
https://docs.mirantis.com/openstack/fuel/fuel-6.1/file-ref.html#astute-yaml-master-ref

about second doc was created bug https://bugs.launchpad.net/fuel/+bug/1496884

Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
Alexey Shtokolov (ashtokolov) wrote :

"Add section into dnsmasq.template" is a wrong way. The primary source is astute now. We just need to upgrade docs.

Revision history for this message
Vladimir Kuklin (vkuklin) wrote :

This bug reopening is invalid. The fix assumes that we edit astute.yaml. Editing cobbler template is a wrong way. Please create another bug related to documentation

Changed in fuel:
status: Confirmed → Fix Committed
no longer affects: fuel/7.0.x
Revision history for this message
Nastya Urlapova (aurlapova) wrote :

Verified on RC4 #301

Changed in fuel:
status: Fix Committed → Fix Released
Alexey Stupnikov (astupnikov)
tags: added: wontfix-feature
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.