Using "keystone-manage domain_config_upload --all" with an empty /etc/keystone/domains directory results in no feedback

Bug #1472059 reported by lumeihong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Medium
David Stanek

Bug Description

When the /etc/keystone/domains directory is empty, execute "keystone-manage domain_config_upload --all" without no information notification .Maybe it can show no file can be loaded.

Revision history for this message
Steve Martinelli (stevemar) wrote :

what's the result of running the command?

Revision history for this message
lumeihong (lu-meihong) wrote :

there is no result to show,so i think that it is loaded successful and automatically create a file.But in fact,there is also nothing in that directory.In order to avoid misunderstanding as above,can some messages be added to prompt no file to be loaded? The operation steps are as follows:
[root@ keystone]# pwd
/etc/keystone
[root@ keystone]# mkdir domains
[root@ ~(keystone_admin)]# keystone-manage domain_config_upload --all
[root@ ~(keystone_admin)]#

Revision history for this message
Dolph Mathews (dolph) wrote :

If there's no work to do, why would there be any output? I'd expect an exit code of 0, too.

Changed in keystone:
status: New → Incomplete
Revision history for this message
lumeihong (lu-meihong) wrote :

so,it is need to explicit notice user there is no work to do.Otherwise,i think it is successful.

Revision history for this message
David Stanek (dstanek) wrote :
Changed in keystone:
assignee: nobody → David Stanek (dstanek)
status: Incomplete → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to keystone (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/279352

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/279353

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/279352
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=61706dc8181fb8645905e43e5772c382deef5f96
Submitter: Jenkins
Branch: master

commit 61706dc8181fb8645905e43e5772c382deef5f96
Author: David Stanek <email address hidden>
Date: Thu Feb 11 17:49:31 2016 +0000

    Extracts logic for finding domain configs

    The logic for finding configs shouldn't be mixed up with the logic for
    procssing those configs. This refactoring also allows the logic to be
    more easily mocked.

    Change-Id: Ie5ec034bca72d61e0b4de63e480be06959ee8583
    Related-Bug: 1472059

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/279353
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=36f7aa0e56654ebb9b833d1c5eec0b341dbe6034
Submitter: Jenkins
Branch: master

commit 36f7aa0e56654ebb9b833d1c5eec0b341dbe6034
Author: David Stanek <email address hidden>
Date: Thu Feb 11 18:57:46 2016 +0000

    Adds better logging to the domain config finder

    There was no feedback for files that did't match the pattern at all. So
    if you had a config keystone.domain.confg (because of a mistype) you
    wouldn't get feedback saying that your config was or wasn't being used.

    Change-Id: I53b446d0413bd1acda420626d4a7e111e4b97f4f
    Related-Bug: 1472059

Changed in keystone:
milestone: none → mitaka-3
importance: Undecided → Medium
summary: - When the /etc/keystone/domains directory is empty, the command of
- "keystone-manage domain_config_upload --all" can be executed
+ Using "keystone-manage domain_config_upload --all" with an empty
+ /etc/keystone/domains directory results in no feedback
Revision history for this message
Steve Martinelli (stevemar) wrote :

patch is marked as WIP, removing the mitaka-3 milestone as it is not critical

Changed in keystone:
milestone: mitaka-3 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/279354
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=4e0fdfabb4e4541dc041dab5ebb100d186fef58c
Submitter: Jenkins
Branch: master

commit 4e0fdfabb4e4541dc041dab5ebb100d186fef58c
Author: David Stanek <email address hidden>
Date: Fri Feb 12 01:11:45 2016 +0000

    Refactor domain config upload

    This gets the code ready for a change that will allow us to know if, and
    how many, config files get uploaded.

    Related-Bug: #1472059
    Change-Id: I8f4f6dbb58f24a41026be2c2624316cc350a2ea8

Revision history for this message
Steve Martinelli (stevemar) wrote :

Automatically unassigning due to inactivity.

Changed in keystone:
assignee: David Stanek (dstanek) → nobody
status: In Progress → Triaged
Changed in keystone:
assignee: nobody → David Stanek (dstanek)
status: Triaged → In Progress
Changed in keystone:
milestone: none → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/214287
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=1c38db61ec116eea552fe88afd48eeac32574ad4
Submitter: Jenkins
Branch: master

commit 1c38db61ec116eea552fe88afd48eeac32574ad4
Author: David Stanek <email address hidden>
Date: Tue Aug 18 16:56:27 2015 +0000

    Adds warning when no domain configs were uploaded

    The 'keystone-manage domain_config_upload --all' previously didn't tell
    the admin that there wasn't any files to upload. This means it was
    possible for them to have put their configs in the wrong directory and
    not know it.

    Change-Id: Ib9ace1cc9654d4a32c9110eb5452c895605caf95
    Closes-bug: #1472059

Changed in keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/keystone 11.0.0.0b1

This issue was fixed in the openstack/keystone 11.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.