incorrect RPCVersionCapError message

Bug #1468525 reported by Corey Wright
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
oslo.messaging
Fix Released
Undecided
Corey Wright

Bug Description

RPCVersionCapError: Requested message version, 3.23 is too high. It needs to be lower than the specified version cap 4.0.

huh? 3.23 > 4.0?!

but reading the code, specifically version_is_compatible() in oslo_messaging/_utils.py, the actual problem is a difference in major version numbers (as major versions, eg 3 and 4, are assumed to be incompatible).

the RPCVersionCapError exception is only raised in the oslo.messaging code base when oslo_messaging._utils.version_is_compatible is false and that only happens when major versions differ and requested message minor and revision versions are less than specified version cap minor and revision versions (evaluated in that order). i suggest that the current algorithm be reflected in the exception (and log) message.

if RPCVersionCapError is intended to communicate generic version incompatibility (broader than the algorithm implemented in version_is_compatible; ie don't create dependency between RPCVersionCapError message and version_is_compatible algorithm which reside in two different files and are not explicitly tied to one another), then maybe the message needs to be generalized to "Requested message version, X is incompatible with the specified version cap Y" (and not dive into the, potentially incorrect or bound-to-change-in-the-future, details).

Changed in oslo.messaging:
assignee: nobody → Corey Wright (coreywright)
status: New → In Progress
Changed in oslo.messaging:
status: In Progress → Fix Committed
Changed in oslo.messaging:
milestone: none → 1.16.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.