Mir

Spurious Failure in ClientLibrary.highly_threaded_client

Bug #1466492 reported by Kevin DuBois
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
High
Alberto Aguirre
Mir 0.14.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

I noticed ClientLibrary.highly_threaded_client failing (approx 3/10 times) with this message with mir rev 2681.

Note: Google Test filter = ClientLibrary.highly_threaded*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ClientLibrary
[ RUN ] ClientLibrary.highly_threaded_client
/home/kdub/source/mir/mir/tests/acceptance-tests/test_client_library.cpp:555: Failure
Value of: mir_surface_get_state(surface)
Expected: is equal to 7
  Actual: 2 (of type MirSurfaceState)
[ FAILED ] ClientLibrary.highly_threaded_client (25 ms)
[----------] 1 test from ClientLibrary (25 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (25 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] ClientLibrary.highly_threaded_client

 1 FAILED TEST

Tags: testsfail

Related branches

lp://staging/~afrantzis/mir/fix-1466492-map-minimized-to-hidden
Rejected for merging into lp://staging/mir
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Alberto Aguirre (community): Disapprove
Diff: 37 lines (+19/-0)
2 files modified
src/server/shell/canonical_window_manager.cpp (+2/-0)
tests/acceptance-tests/test_surface_modifications.cpp (+17/-0)
lp://staging/~albaguirre/mir/no-minimize-to-hidden-mapping
PS Jenkins bot (community): Approve (continuous-integration)
Alan Griffiths: Approve
Alexandros Frantzis (community): Approve
Diff: 69 lines (+3/-12)
5 files modified
examples/server_example_canonical_window_manager.cpp (+1/-3)
src/server/scene/basic_surface.cpp (+0/-2)
src/server/shell/canonical_window_manager.cpp (+1/-3)
tests/acceptance-tests/test_client_library.cpp (+1/-1)
tests/unit-tests/scene/test_basic_surface.cpp (+0/-3)
lp://staging/ubuntu/wily-proposed/mir
Kevin DuBois (kdub)
Changed in mir:
importance: Undecided → High
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

That test is a few years old so I thought it was solid. Did we break MirWaitHandle (or surface state getting)?

Alexandros Frantzis (afrantzis)
Changed in mir:
assignee: nobody → Alexandros Frantzis (afrantzis)
Alexandros Frantzis (afrantzis)
Changed in mir:
status: New → Triaged
assignee: Alexandros Frantzis (afrantzis) → Alberto Aguirre (albaguirre)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.14.0

Changed in mir:
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.14.0+15.10.20150722-0ubuntu1

---------------
mir (0.14.0+15.10.20150722-0ubuntu1) wily; urgency=medium

  [ Andreas Pokorny ]
  * Fix missing ABI renaming in Mirplatform
  * Bump Mirserver platform graphics to 3
  * Fix mirprotobuf ABI break

  [ CI Train Bot ]
  * New rebuild forced.

 -- CI Train Bot <email address hidden> Wed, 22 Jul 2015 18:01:49 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
Daniel van Vugt (vanvugt)
Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.