apiserver tests fail on windows

Bug #1466011 reported by Martin Packman
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Roger Peppe
juju-core
Fix Released
Critical
Dave Cheney

Bug Description

A number of tests in the apiserver package fail trying to connect over a websocket on ipv6:

<http://reports.vapour.ws/releases/issue/55813a91749a5648d8767d60>

[LOG] 0:00.568 INFO juju.api dialing "wss://[::]:57635/environment/deadbeef-0bad-400d-8000-4b1d0d06f00d/api"
[LOG] 0:00.569 INFO juju.api error dialing "wss://[::]:57635/environment/deadbeef-0bad-400d-8000-4b1d0d06f00d/api": websocket.Dial wss://[::]:57635/environment/deadbeef-0bad-400d-8000-4b1d0d06f00d/api: dial tcp [::]:57635: ConnectEx tcp: The requested address is not valid in its context.

Almost certainly introduced by the switch to using *net.TCPAddr:

<http://reviews.vapour.ws/r/1928/>

Martin Packman (gz)
affects: juju-ci-tools → juju-core
Changed in juju-core:
milestone: none → 1.25.0
Changed in juju-core:
status: Triaged → In Progress
assignee: nobody → Dave Cheney (dave-cheney)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
Changed in juju:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Menno Smits (menno.smits)
milestone: none → 2.0.0
Revision history for this message
Menno Finlay-Smits (menno.smits) wrote :

This has resurfaced on 2.0. It's likely the problem was introduced by 363ae822. It seems that net.Dial on Windows can't handle ":<port>" style addresses.

See:
https://github.com/golang/go/issues/6290
https://github.com/golang/go/issues/15216

Changed in juju:
assignee: Menno Smits (menno.smits) → nobody
Revision history for this message
Menno Finlay-Smits (menno.smits) wrote :

I was going to work on this but I'm out of time for today. Pinging rog.

Curtis Hovey (sinzui)
Changed in juju:
status: Confirmed → Triaged
description: updated
Changed in juju:
assignee: nobody → Roger Peppe (rogpeppe)
status: Triaged → Fix Committed
Curtis Hovey (sinzui)
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.