OpenStack Dashboard (Horizon)

refactor checking env. var INTEGRATION_TESTS

Bug #1463729 reported by Martin Pavlásek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Martin Pavlásek
OpenStack Dashboard (Horizon) newton-1 "n1"

Bug Description

There is positive branch, much bigger than negative (it just raise exception). It's not so clear and this nesting is no necessary at all.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/190077

Changed in horizon:
assignee: nobody → Martin Pavlásek (mpavlase)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/190077
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Undecided → Low
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/190077
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8e9b609fc63b15f8077e3e646f5f20b416dc7335
Submitter: Jenkins
Branch: master

commit 8e9b609fc63b15f8077e3e646f5f20b416dc7335
Author: Martin Pavlasek <email address hidden>
Date: Wed Jun 10 10:53:38 2015 +0200

    Refactor of BaseTestCase

    Made code more readable by check conditions first.

    Closes-Bug: 1463729
    Partially implements blueprint: selenium-integration-testing
    Change-Id: I34edd7261022f7a0a441e0716be8b84f90e8cde9

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/horizon 10.0.0.0b1

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.