kolla

TechDebt: simplify list of excluded directories in bashate tox

Bug #1462801 reported by Steven Dake on 2015-06-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	kolla	Invalid	Low	Unassigned	kolla ocata-3 "o3"

Bug Description

In tox.ini there is a command:

bash -c "files=`egrep -rlI --exclude-dir .git --exclude-dir .tox '^[[:punct:]]+!/(bin/|/usr/bin/
env )(ba)?sh' .` && bashate $files"

It would be ideal if tox.ini could instead take something like

--exclude-dir={.git,.tox}

But this results in errors. Escaping with --exclude-dir=\{.git,.tox\} as recommended by the tox documentation also results in errors.

The error is:
"substitution key %r not found" % key)
tox.ConfigError: ConfigError: substitution key '.git,.tox\\' not found

Steven Dake (sdake) on 2015-06-07

Changed in kolla:
status:	New → Confirmed
importance:	Undecided → Wishlist

Revision history for this message

Jeff Peeler (jpeeler-z) wrote on 2015-06-08:

I had difficulty using tox for regex quantifiers, which also uses brackets {}. Surely some form of escaping works though.

Revision history for this message

Steven Dake (sdake) wrote on 2015-06-08:

Agree should be possible. It isn't like I didn't try :) I am in a bit of a rush to finish the bashate gating tho and don't want to block on this detail. Hence the tracking as techdebt ;)

Steven Dake (sdake) on 2015-08-29

Changed in kolla:
milestone:	none → liberty-rc1

Steven Dake (sdake) on 2015-09-28

Changed in kolla:
milestone:	liberty-rc1 → liberty-rc2

Steven Dake (sdake) on 2015-10-11

Changed in kolla:
milestone:	liberty-rc2 → liberty-rc3

Michal Rostecki (mrostecki) on 2015-10-12

Changed in kolla:
assignee:	nobody → Michal Rostecki (mrostecki)

Steven Dake (sdake) on 2015-10-12

Changed in kolla:
milestone:	liberty-rc3 → mitaka-1

Michal Rostecki (mrostecki) on 2015-10-13

Changed in kolla:
assignee:	Michal Rostecki (mrostecki) → nobody

Maciej Szankin (mszankin) on 2015-11-25

Changed in kolla:
assignee:	nobody → Maciej Szankin (mszankin)

Steven Dake (sdake) on 2016-01-06

Changed in kolla:
milestone:	mitaka-1 → mitaka-2

Steven Dake (sdake) on 2016-01-22

Changed in kolla:
milestone:	mitaka-2 → mitaka-3

Steven Dake (sdake) on 2016-03-05

Changed in kolla:
milestone:	mitaka-3 → mitaka-rc1

Steven Dake (sdake) on 2016-03-17

Changed in kolla:
milestone:	mitaka-rc1 → mitaka-rc2

Revision history for this message

Steven Dake (sdake) wrote on 2016-03-22:

this is a low priority techdebt bug. Moving to newton 1.

Changed in kolla:
milestone:	mitaka-rc2 → newton-1
importance:	Wishlist → Low

Maciej Szankin (mszankin) on 2016-04-19

Changed in kolla:
assignee:	Maciej Szankin (mszankin) → nobody

Steven Dake (sdake) on 2016-06-23

Changed in kolla:
milestone:	newton-1 → newton-2

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-07-20

Changed in kolla:
milestone:	newton-2 → newton-3

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-09-01

Changed in kolla:
milestone:	newton-3 → occata-1

Jeffrey Zhang (jeffrey4l) on 2016-11-18

Changed in kolla:
milestone:	ocata-1 → ocata-2

Jeffrey Zhang (jeffrey4l) on 2016-12-16

Changed in kolla:
milestone:	ocata-2 → ocata-3

Revision history for this message

Christian Berendt (berendt) wrote on 2016-12-16:

Closing as invalid. We now have a script called tools/run-bashate.sh. In the tox.ini we use "{toxinidir}/tools/run-bashate.sh".

Changed in kolla:
status:	Confirmed → Invalid

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.