many unhandled assigned values

Bug #1460893 reported by Dave Cheney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Medium
Dave Cheney

Bug Description

Spotted with Gordon Klass's `ineffassign`

% ineffassign ~/src/github.com/juju/juju
/home/dfc/src/github.com/juju/juju/api/agent/unit_test.go:36:2 err
/home/dfc/src/github.com/juju/juju/apiserver/admin_test.go:265:2 connectedAddr
/home/dfc/src/github.com/juju/juju/apiserver/client/client_test.go:3220:2 err
/home/dfc/src/github.com/juju/juju/apiserver/client/client_test.go:2239:8 err
/home/dfc/src/github.com/juju/juju/apiserver/highavailability/highavailability_test.go:291:12 err
/home/dfc/src/github.com/juju/juju/apiserver/service/service_test.go:179:2 settings
/home/dfc/src/github.com/juju/juju/apiserver/uniter/uniter_base_test.go:2257:2 err
/home/dfc/src/github.com/juju/juju/cloudconfig/sshinit/configure.go:59:3 client
/home/dfc/src/github.com/juju/juju/cmd/juju/service/constraints.go:82:17 args
/home/dfc/src/github.com/juju/juju/environs/tools/simplestreams_test.go:829:7 err
/home/dfc/src/github.com/juju/juju/instance/container_test.go:35:2 ctype
/home/dfc/src/github.com/juju/juju/instance/container_test.go:52:2 ctype
/home/dfc/src/github.com/juju/juju/provider/cloudsigma/instance_test.go:98:9 err
/home/dfc/src/github.com/juju/juju/provider/ec2/environ.go:152:4 defaultVpcId
/home/dfc/src/github.com/juju/juju/provider/gce/google/errors.go:65:4 msg
/home/dfc/src/github.com/juju/juju/state/backups/db_restore_test.go:56:2 args
/home/dfc/src/github.com/juju/juju/state/status_test.go:57:11 err
/home/dfc/src/github.com/juju/juju/state/watcher/watcher_test.go:500:2 revno3
/home/dfc/src/github.com/juju/juju/worker/uniter/filter/filter_test.go:288:2 err
/home/dfc/src/github.com/juju/juju/worker/uniter/util_test.go:1282:2 meta

Tags: tech-debt
Changed in juju-core:
importance: Undecided → Medium
Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Triaged
Changed in juju-core:
status: Triaged → In Progress
assignee: nobody → Dave Cheney (dave-cheney)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
milestone: none → 1.25.0
tags: added: tech-debt
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.