Stored key certificate order does not set PK on generated container

Bug #1459454 reported by John Wood
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Barbican
Fix Released
High
Juan Antonio Osorio Robles

Bug Description

When a certificate-type order is placed with the 'stored-key' request type, the generated certificate-type container does not have the 'private-key' secret reference filled out.

So the following sequence reveals the error:

1) Place an asymmetric-type order with Barbican, which should eventually produce an asymmetric-type container, with a 'private-key' secret reference to the stored encrypted private key.

2) Place a certificate-type order with Barbican, with the container-ref set to the asymmetric key from step (1).

3) View the certificate-type container generated from (2). It does not have the 'private-key' reference filled out, but should have the same one set in (1) above (hence this private-key secret will be in two containers at once).

Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

Was this supposed to be the expected behaviour? Seems to me like none of the plugins take this into consideration. And even the ResultDTO that's gotten from the certificate order has no reference of a private key in it.

Revision history for this message
John Wood (john-wood-w) wrote :

Ozz, Barbican 'core' (so outside of plugins) should handle setting the private key on the generated cert container for the stored-key case. Core is already creating this container outside of the plugins, so this would just be an extra step added to that sequence.

Changed in barbican:
assignee: nobody → Juan Antonio Osorio Robles (juan-osorio-robles)
Changed in barbican:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to barbican (master)

Reviewed: https://review.openstack.org/199142
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=cf9e040397dad0fb7c15c2ab180d913ab18ca29b
Submitter: Jenkins
Branch: master

commit cf9e040397dad0fb7c15c2ab180d913ab18ca29b
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Tue Jul 7 18:00:14 2015 +0300

    Add Private Key to the resulting container if stored-key order

    If a stored-key type order is made, the resulting container should have a
    reference to that given private key. This CR fixes and enables that.

    Change-Id: Ic72394f21dce692e80c53ec32a59efd7f8e16d8d
    Closes-Bug: #1459454

Changed in barbican:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in barbican:
milestone: none → liberty-2
status: Fix Committed → Fix Released
Changed in barbican:
importance: Undecided → High
Thierry Carrez (ttx)
Changed in barbican:
milestone: liberty-2 → 1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.