Triple click doesn't work
Bug #1459395 reported by
Chris Coulson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Oxide |
Fix Released
|
High
|
Justin McPherson | ||
Bug Description
Double-clicking correctly selects the nearest whole word, but triple-clicking should select all of the text in a particular div. This currently doesn't work though.
The issue is that we don't track the click count in Oxide - we rely on QEvent:
Related branches
lp://staging/~justinmcp/oxide/1459395
- Chris Coulson: Approve
-
Diff: 298 lines (+137/-25)11 files modifiedqt/core/browser/oxide_qt_browser_platform_integration.cc (+5/-0)
qt/core/browser/oxide_qt_browser_platform_integration.h (+1/-0)
qt/core/browser/oxide_qt_event_utils.cc (+2/-2)
qt/quick/api/oxideqquickwebview.cc (+1/-11)
qt/quick/api/oxideqquickwebview_p.h (+0/-1)
shared/browser/oxide_browser_platform_integration.h (+4/-0)
shared/browser/oxide_mouse_event_state.cc (+74/-0)
shared/browser/oxide_mouse_event_state.h (+44/-0)
shared/browser/oxide_web_view.cc (+2/-10)
shared/browser/oxide_web_view.h (+2/-1)
shared/shared.gyp (+2/-0)
| Changed in oxide: | |
| assignee: | nobody → Chris Coulson (chrisccoulson) |
| milestone: | none → branch-1.9 |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in oxide: | |
| assignee: | Chris Coulson (chrisccoulson) → Justin McPherson (justinmcp) |
| Changed in oxide: | |
| status: | Triaged → In Progress |
| Changed in oxide: | |
| milestone: | branch-1.9 → branch-1.10 |
| Changed in oxide: | |
| milestone: | branch-1.10 → branch-1.11 |
| Changed in oxide: | |
| milestone: | branch-1.11 → branch-1.12 |
| Changed in oxide: | |
| milestone: | branch-1.12 → branch-1.13 |
| Changed in oxide: | |
| milestone: | branch-1.13 → branch-1.14 |
| status: | In Progress → Fix Released |
To post a comment you must log in.
