juju-core

lease: data races in tests

Bug #1458721 reported by Dave Cheney
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
Medium
Dave Cheney
juju-core 1.25-alpha1

Bug Description

==================
WARNING: DATA RACE
Read by goroutine 42:
  github.com/juju/juju/lease.(*leaseSuite).TestLeaseExpiration.func2()
      /home/dfc/src/github.com/juju/juju/lease/lease_test.go:323 +0xb4

Previous write by goroutine 40:
  github.com/juju/juju/lease.(*leaseSuite).TestLeaseExpiration()
      /home/dfc/src/github.com/juju/juju/lease/lease_test.go:339 +0x361
  runtime.call32()
      /home/dfc/go/src/runtime/asm_amd64.s:421 +0x44
  reflect.Value.Call()
      /home/dfc/go/src/reflect/value.go:300 +0xd0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:763 +0x600
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:657 +0x83

Goroutine 42 (running) created at:
  github.com/juju/juju/lease.(*leaseSuite).TestLeaseExpiration()
      /home/dfc/src/github.com/juju/juju/lease/lease_test.go:335 +0x2c3
  runtime.call32()
      /home/dfc/go/src/runtime/asm_amd64.s:421 +0x44
  reflect.Value.Call()
      /home/dfc/go/src/reflect/value.go:300 +0xd0
  gopkg.in/check%2ev1.(*suiteRunner).forkTest.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:763 +0x600
  gopkg.in/check%2ev1.(*suiteRunner).forkCall.func1()
      /home/dfc/src/gopkg.in/check.v1/check.go:657 +0x83

Goroutine 40 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/dfc/src/gopkg.in/check.v1/check.go:658 +0x4c2
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /home/dfc/src/gopkg.in/check.v1/check.go:795 +0x13a
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /home/dfc/src/gopkg.in/check.v1/check.go:800 +0x3f
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /home/dfc/src/gopkg.in/check.v1/check.go:606 +0x4a2
  gopkg.in/check%2ev1.Run()
      /home/dfc/src/gopkg.in/check.v1/run.go:92 +0x57
  gopkg.in/check%2ev1.RunAll()
      /home/dfc/src/gopkg.in/check.v1/run.go:84 +0x136
  gopkg.in/check%2ev1.TestingT()
      /home/dfc/src/gopkg.in/check.v1/run.go:72 +0x4b0
  github.com/juju/juju/lease.Test()
      /home/dfc/src/github.com/juju/juju/lease/lease_test.go:19 +0x35
  testing.tRunner()
      /home/dfc/go/src/testing/testing.go:454 +0xfb
==================
OK: 14 passed
PASS
Found 1 data race(s)
FAIL github.com/juju/juju/lease 2.174s

Dave Cheney (dave-cheney)
Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
status: New → In Progress
Dave Cheney (dave-cheney)
Changed in juju-core:
status: In Progress → Fix Committed
status: Fix Committed → In Progress
Dave Cheney (dave-cheney)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
importance: Undecided → Medium
milestone: none → 1.25.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.