Murano

environment is being deleted even though en error ocurred

Bug #1456724 reported by Kirill Zaitsev
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Kirill Zaitsev
Murano mitaka-1 "m1"
Kilo
Fix Committed
Undecided
Kirill Zaitsev

Bug Description

To reproduce:

1) create an env
2) add an app to the env
3) deploy the env
4) delete the package, containing the app
5) delete the env

Environment deletion should fail, but it doesn't. The env get's deleted, but destroy methods and heat stack is not deleted

Expected result: environment enters state DELETION_FAILURE

This behaviour was supposedly introduced by https://review.openstack.org/#/c/179533/ commit

See original description
Kirill Zaitsev (kzaitsev)
description: updated
Kirill Zaitsev (kzaitsev)
Changed in murano:
importance: Undecided → Medium
Ekaterina Chernova (efedorova)
Changed in murano:
status: New → Confirmed
milestone: none → 2015.1.1
milestone: 2015.1.1 → liberty-1
Kirill Zaitsev (kzaitsev)
Changed in murano:
importance: Medium → High
Kirill Zaitsev (kzaitsev)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/188531

Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
status: Confirmed → In Progress
Serg Melikyan (smelikyan)
Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

The commit was not merged, so the bug is still convirmed

Changed in murano:
status: Fix Released → Confirmed
Kirill Zaitsev (kzaitsev)
Changed in murano:
status: Confirmed → In Progress
tags: added: kilo-backport-potential
Nikolay Starodubtsev (starodubcevna)
Changed in murano:
assignee: Kirill Zaitsev (kzaitsev) → Nikolay Starodubtsev (starodubcevna)
Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: Nikolay Starodubtsev (starodubcevna) → Kirill Zaitsev (kzaitsev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/207996

Changed in murano:
assignee: Kirill Zaitsev (kzaitsev) → Nikolay Starodubtsev (starodubcevna)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/188531
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=1e62fafe8212a1e2eb4d5f2bad3da2d8c88a33fe
Submitter: Jenkins
Branch: master

commit 1e62fafe8212a1e2eb4d5f2bad3da2d8c88a33fe
Author: Kirill Zaitsev <email address hidden>
Date: Thu Jun 4 20:50:14 2015 +0300

    Include original ObjectsCopy/Attributes in exception_result

    Before if an exception occured during dsl cleanup exception_result would
    use empty ObjectsCopy and empty Attributes for result. In case exception
    happened during env deletion this would cause env to be deleted by API,
    because it ignored isException and treated any result as valid.

    Now exception_result also includes original ObjectsCopy/Attributes in case
    they're empty in exception_result.
    Api not only checks count of 'error' statuses, in session, but also
    checks isException attribute of the result, and treats exception results
    as Errors, therefore marking deployment/deletion as failed.

    Logging of results in API is now aware, that objects can be empty during
    app deletion and no longer throws AttributeError because of that.

    Change-Id: Idec8191ee25d1cac606741673719bbb8a72709b0
    Closes-Bug: #1456724

Changed in murano:
status: In Progress → Fix Committed
Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: Nikolay Starodubtsev (starodubcevna) → Kirill Zaitsev (kzaitsev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/208957

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/208960

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/207996
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=3864669dcbe0c858a3a6b0d4338541c0c55b277e
Submitter: Jenkins
Branch: master

commit 3864669dcbe0c858a3a6b0d4338541c0c55b277e
Author: Nikolay Starodubtsev <email address hidden>
Date: Fri Jul 31 19:57:54 2015 +0300

    Add possibilty to delete environment with incorrect .destroy method

    In this patch we introduce a possibility to delete an environment
    which contains a package with incorrect .destroy method. Previously
    such kind of environment was stucked in 'Deletion failure' status
    and we can't do anything with that, now murano environment and heat
    stack will be deleted completely.
    partial-bug: 1456724

    Change-Id: I90dfa4e6e30c325a17e746c36a4e467189834294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/kilo)

Reviewed: https://review.openstack.org/208960
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=4d7da4a9d16a62383d3f9b621630c156fa5cdfd6
Submitter: Jenkins
Branch: stable/kilo

commit 4d7da4a9d16a62383d3f9b621630c156fa5cdfd6
Author: Nikolay Starodubtsev <email address hidden>
Date: Fri Jul 31 19:57:54 2015 +0300

    Add possibilty to delete environment with incorrect .destroy method

    In this patch we introduce a possibility to delete an environment
    which contains a package with incorrect .destroy method. Previously
    such kind of environment was stucked in 'Deletion failure' status
    and we can't do anything with that, now murano environment and heat
    stack will be deleted completely.
    partial-bug: 1456724

    Change-Id: I90dfa4e6e30c325a17e746c36a4e467189834294

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/208957
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=87a89dbda14b8306f181fdffef41ac3f0b87a628
Submitter: Jenkins
Branch: stable/kilo

commit 87a89dbda14b8306f181fdffef41ac3f0b87a628
Author: Kirill Zaitsev <email address hidden>
Date: Thu Jun 4 20:50:14 2015 +0300

    Include original ObjectsCopy/Attributes in exception_result

    Before if an exception occured during dsl cleanup exception_result would
    use empty ObjectsCopy and empty Attributes for result. In case exception
    happened during env deletion this would cause env to be deleted by API,
    because it ignored isException and treated any result as valid.

    Now exception_result also includes original ObjectsCopy/Attributes in case
    they're empty in exception_result.
    Api not only checks count of 'error' statuses, in session, but also
    checks isException attribute of the result, and treats exception results
    as Errors, therefore marking deployment/deletion as failed.

    Logging of results in API is now aware, that objects can be empty during
    app deletion and no longer throws AttributeError because of that.

    Change-Id: Idec8191ee25d1cac606741673719bbb8a72709b0
    Closes-Bug: #1456724
    (cherry picked from commit 1e62fafe8212a1e2eb4d5f2bad3da2d8c88a33fe)

Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-1 → 1.0.0
Serg Melikyan (smelikyan)
Changed in murano:
milestone: 1.0.0 → mitaka-1
Kirill Zaitsev (kzaitsev)
Changed in murano:
status: Fix Committed → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano 2015.1.1

This issue was fixed in the openstack/murano 2015.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/murano 2015.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.