Fuel for OpenStack

Fix RabbitMQ OCF kill command

Bug #1455880 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
Medium
Bogdan Dobrelya
Fuel for OpenStack 6.1
5.1.x
Won't Fix
Medium
MOS Maintenance
Fuel for OpenStack 5.1.1-updates
6.0.x
Won't Fix
Medium
MOS Maintenance
Fuel for OpenStack 6.0-updates

Bug Description

For some cases, when rabbit app cannot be stopped gracefully, the kill -9 command invoked. And there is a situation possible when messages like

2015-05-15T14:21:35.898497+00:00 warning: WARNING: p_rabbitmq-server: stop_server_process(): RMQ-server process (PID=15062) stopped by 'kill -9', sorry...
2015-05-15T14:21:35.901624+00:00 err: ERROR: kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]

would be recorded. It looks like an empty pid argument is given to the kill command, thus must be fixed

See original description
Tags: rabbitmq
Bogdan Dobrelya (bogdando)
Changed in fuel:
assignee: nobody → Bogdan Dobrelya (bogdando)
tags: added: rabbitmq
description: updated
Changed in fuel:
status: New → Confirmed
importance: Undecided → High
milestone: none → 6.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/183907

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/183907
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=dc1b2602a32d0e9271894436d010be32bd4cf3eb
Submitter: Jenkins
Branch: master

commit dc1b2602a32d0e9271894436d010be32bd4cf3eb
Author: Bogdan Dobrelya <email address hidden>
Date: Sun May 17 12:58:25 2015 +0200

    Fix kill for rabbit OCF

    * There is undefined stop_pid argument could be
    passed to the kill command for some cases when rabbit
    app cannot be stopped gracefully. Renamed to pid.
    * There is also unnecessary "kill" code duplication exist
    and is removed.
    * The pid value passed for the kill command is now always
    verified to be not empty.

    Closes-bug: #1455880

    Change-Id: I0af8e275873c08fd44d3fc3abf40b7e99674986d
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Vladimir Kuklin (vkuklin)
Changed in fuel:
status: Fix Committed → In Progress
importance: High → Medium
status: In Progress → Won't Fix
Revision history for this message
Vitaly Sedelnik (vsedelnik) wrote :

Won't Fix for 5.1.1-updates and 6.0-updates because of Medium importance

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.