Fuel for OpenStack

[fuel-library][rabbit][ocf] Rabbit ocf script does not handle limit settings properly

Bug #1455755 reported by slava valyavskiy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Invalid
High
Bartłomiej Piotrowski
Fuel for OpenStack 6.1
7.0.x
In Progress
Medium
Bartłomiej Piotrowski
Fuel for OpenStack 7.0

Bug Description

Currently, ocf should take limits configuration from "/etc/default/rabbitmq-server" file. But, if we change limits configuration via this file it will take on effect.

https://github.com/stackforge/fuel-library/blob/master/deployment/puppet/cluster/files/ocf/rabbitmq#L698

We initialize limits for current root user, but we run all rabbitmq processes using rabbimq user wrapper.

As a workaround we can add "/etc/security/limits.d/rabbit.conf" and put necessary configuration into it:
####
# Raising open file limit for Rabbitmq services
rabbitmq soft nofile 80000
rabbitmq hard nofile 112640
####

In other way, global system limits will used.

As a second option we can inject call "[ -f /etc/default/rabbitmq-server ] && . /etc/default/rabbitmq-server" into rabbitmq-env.conf file.

See original description
slava valyavskiy (slava-val-al)
description: updated
Vladimir Kuklin (vkuklin)
Changed in fuel:
importance: Undecided → High
assignee: nobody → Fuel Library Team (fuel-library)
milestone: none → 6.1
status: New → Triaged
Oleksiy Molchanov (omolchanov)
tags: added: low-hanging-fruit
Bartłomiej Piotrowski (bpiotrowski)
Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Bartlomiej Piotrowski (bpiotrowski)
slava valyavskiy (slava-val-al)
tags: added: customer-found
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/183787

Changed in fuel:
status: Triaged → In Progress
OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: Bartlomiej Piotrowski (bpiotrowski) → Oleksiy Molchanov (omolchanov)
Oleksiy Molchanov (omolchanov)
Changed in fuel:
assignee: Oleksiy Molchanov (omolchanov) → Bartlomiej Piotrowski (bpiotrowski)
Revision history for this message
Sergii Golovatiuk (sgolovatiuk) wrote :

This bug is invalid as /etc/default/rabbitmq-server always applies to rabbitmq processes. All processes spawned by it inherit its settings.

Changed in fuel:
status: In Progress → Invalid
Revision history for this message
Sergii Golovatiuk (sgolovatiuk) wrote :

I had a discussion with Slava.

Firstly, the bug was discovered in 6.0 though bug was opened for master. We agreed to provide ISO version and diagnostic status.
Secondly, the bug was fixed by

https://review.openstack.org/#/q/Ia63e9eae2344535a2b0213c0fb2e9693c6317735,n,z

Changed in fuel:
milestone: 6.1 → 6.0.1-mu-1
milestone: 6.0.1-mu-1 → 6.0.1
Bartłomiej Piotrowski (bpiotrowski)
Changed in fuel:
milestone: 6.0.1 → 6.1
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

# grep files /proc/$(pidof beam.smp)/limits
Max open files 102400 112640 files

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (master)

Change abandoned by Bartłomiej Piotrowski (<email address hidden>) on branch: master
Review: https://review.openstack.org/183787
Reason: Fixed in https://bugs.launchpad.net/fuel/+bug/1405657

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.