Murano

[Murano]Page with env components is in infinite reload state after deployment of a few apps

Bug #1454221 reported by Anastasia Kuznetsova
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Kirill Zaitsev
Murano 1.0.1
Kilo
Fix Released
Undecided
Kirill Zaitsev

Bug Description

Step to reproduce:
1. Log in Web UI
2. Import a few application packages to the catalog (e.g. Docker apps)
3. Navigate to "Murano" > "Application Catalog" > "Environments"
4. Create environment and add _a few_ applications to it
5. Send environment to deploy and _stay_ on page with environment components

Observed result:
After finish of deployment (successful or not) page is in reload page (in Chrome user doesn't see favicon of the page, just load sign) and after clicking on any button happens nothing, all is hanging, user has to sign out and sign in again to continue work.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/182290

Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/182369

Victor Ryzhenkin (vryzhenkin)
Changed in murano:
milestone: none → liberty-1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/182290
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=8aa77dbf43868620ed4e04554f578fa9c7d743f1
Submitter: Jenkins
Branch: master

commit 8aa77dbf43868620ed4e04554f578fa9c7d743f1
Author: Kirill Zaitsev <email address hidden>
Date: Tue May 12 16:23:38 2015 +0300

    Environments: reload page after all the environments have been updated

    Before murano had an overriden datatable script in
    horizon.tables+reload.js. This script was copy-pasted for a single
    single line edit. This is actually not required, because horion
    datatables fire a "update" trigger after row updates,
    which is enough for the purpose of updating the page.

    Before any row in the ready/deploy_failure would trigger a reload.
    With this patch only an update trigger is set for the services table
    instead of overriding whole datatable js routine. The page is
    reloaded only after there are no rows with 'status_unknown', i.e.
    when every app either deployed or failed to deploy.

    Change-Id: I254538cb776d2dee422be0363a736a5a9c1c9e2b
    Closes-Bug: #1454221

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (stable/kilo)

Reviewed: https://review.openstack.org/182369
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=7480d700527741da27c03ef4ca44d8cf00ffca6e
Submitter: Jenkins
Branch: stable/kilo

commit 7480d700527741da27c03ef4ca44d8cf00ffca6e
Author: Kirill Zaitsev <email address hidden>
Date: Tue May 12 16:23:38 2015 +0300

    Environments: reload page after all the environments have been updated

    Before murano had an overriden datatable script in
    horizon.tables+reload.js. This script was copy-pasted for a single
    single line edit. This is actually not required, because horion
    datatables fire a "update" trigger after row updates,
    which is enough for the purpose of updating the page.

    Before any row in the ready/deploy_failure would trigger a reload.
    With this patch only an update trigger is set for the services table
    instead of overriding whole datatable js routine. The page is
    reloaded only after there are no rows with 'status_unknown', i.e.
    when every app either deployed or failed to deploy.

    Change-Id: I254538cb776d2dee422be0363a736a5a9c1c9e2b
    Closes-Bug: #1454221

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/185057

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/185057
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=275b545e5a9a48bdb08afa68f8c3e0520afe02c4
Submitter: Jenkins
Branch: master

commit 275b545e5a9a48bdb08afa68f8c3e0520afe02c4
Author: Kirill Zaitsev <email address hidden>
Date: Fri May 22 18:58:18 2015 +0300

    Call location.reload only once at successfull env deployment

    Before it was possible, that in some configurations table update events
    would stack and reload would be called multiple times.
    This change introduces a global js variable, that would prevent
    location.reload from being called more than once.

    Change-Id: Idb332e56b764d494a51de74398e7098c68561c61
    Related-Bug: #1454221

Kirill Zaitsev (kzaitsev)
tags: added: juno-backport-potential
Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (stable/kilo)

Related fix proposed to branch: stable/kilo
Review: https://review.openstack.org/198890

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (stable/kilo)

Reviewed: https://review.openstack.org/198890
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=6aba78cac65ecdfeda5ef93dd8c0010a4a8c8a03
Submitter: Jenkins
Branch: stable/kilo

commit 6aba78cac65ecdfeda5ef93dd8c0010a4a8c8a03
Author: Kirill Zaitsev <email address hidden>
Date: Fri May 22 18:58:18 2015 +0300

    Call location.reload only once at successfull env deployment

    Before it was possible, that in some configurations table update events
    would stack and reload would be called multiple times.
    This change introduces a global js variable, that would prevent
    location.reload from being called more than once.

    Change-Id: Idb332e56b764d494a51de74398e7098c68561c61
    Related-Bug: #1454221

Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-1 → 1.0.0
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: 1.0.0 → 1.0.1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/murano-dashboard 2015.1.1

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/murano-dashboard 2015.1.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.