Fuel for OpenStack

[fuel-library] Rabbitmq ocf script doesn't fix log files permissions correctly

Bug #1452479 reported by slava valyavskiy
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Critical
slava valyavskiy
Fuel for OpenStack 6.1
5.1.x
Fix Committed
Critical
Bogdan Dobrelya
Fuel for OpenStack 5.1.1-updates
6.0.x
Fix Committed
Critical
Bogdan Dobrelya
Fuel for OpenStack 6.0-updates
6.1.x
Fix Released
Critical
slava valyavskiy
Fuel for OpenStack 6.1

Bug Description

Currently in our ocf rabbitmq script we check only rabbitmq log folder permissions:

####
if ! su -s /bin/sh - $OCF_RESKEY_username -c "test -w ${dir}"; then
    ocf_log warn "Directory ${dir} is not writable by ${OCF_RESKEY_username}, chowning."
    chown -R ${OCF_RESKEY_username}:${OCF_RESKEY_groupname} "${dir}"
fi
####

But, in some case, permissions may be broken for individual files in rabbitmq log folder. I that case, rabbit will not be started correctly and ocf script will not fix permissions issue.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/180780

Changed in fuel:
assignee: nobody → slava valyavskiy (slava-val-al)
status: New → In Progress
Vladimir Kuklin (vkuklin)
Changed in fuel:
milestone: none → 6.1
importance: Undecided → High
Bogdan Dobrelya (bogdando)
no longer affects: fuel/5.0.x
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/180780
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=d00f7bd21b7345ff65d86a4a7156e53245a1a109
Submitter: Jenkins
Branch: master

commit d00f7bd21b7345ff65d86a4a7156e53245a1a109
Author: Valyavskiy Viacheslav <email address hidden>
Date: Thu May 7 01:31:16 2015 +0300

    Add log permissions check for individual files

    Change-Id: I517b2aece3785c2ed93e806b6e92f055a95895f3
    Closes-Bug: #1452479

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Raised to critical as operations impact is very high

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/6.0)

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/183571

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/5.1)

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/183573

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/6.0)

Reviewed: https://review.openstack.org/183571
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=325bdf9ac5a6d4206bea61c66a84cb5222395595
Submitter: Jenkins
Branch: stable/6.0

commit 325bdf9ac5a6d4206bea61c66a84cb5222395595
Author: Valyavskiy Viacheslav <email address hidden>
Date: Thu May 7 01:31:16 2015 +0300

    Add log permissions check for individual files

    Change-Id: I517b2aece3785c2ed93e806b6e92f055a95895f3
    Closes-Bug: #1452479
    (cherry picked from commit d00f7bd21b7345ff65d86a4a7156e53245a1a109)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (stable/5.1)

Reviewed: https://review.openstack.org/183573
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=44c71a42a91ad18d6ecb34fe32e4a68e636d12e5
Submitter: Jenkins
Branch: stable/5.1

commit 44c71a42a91ad18d6ecb34fe32e4a68e636d12e5
Author: Valyavskiy Viacheslav <email address hidden>
Date: Thu May 7 01:31:16 2015 +0300

    Add log permissions check for individual files

    Change-Id: I517b2aece3785c2ed93e806b6e92f055a95895f3
    Closes-Bug: #1452479
    (cherry picked from commit d00f7bd21b7345ff65d86a4a7156e53245a1a109)

Sergey Novikov (snovikov)
tags: added: on-verification
Revision history for this message
Sergey Novikov (snovikov) wrote :

Verified on fuel-6.1-432-2015-05-18_03-43-53.iso.

Steps to verify:
    1. Deploy cluster by fuel devops tool (group="deploy_neutron_vlan_ha")
    2. Run OSTF tests
    3. Check that rabbitmq's dirs have correct permissions

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.