Bug #1450430 “Text selection box drawn in wrong place” : Bugs : webbrowser-app package : Ubuntu

Revision history for this message

Jonathan Cave (jocave) wrote on 2015-04-30:

#1

text-select.png Edit (467.7 KiB, image/png)

Olivier Tilloy (osomon) on 2015-04-30

affects:	oxide-qt (Ubuntu) → webbrowser-app (Ubuntu)
Changed in webbrowser-app (Ubuntu):
status:	New → Confirmed
tags:	added: selection

Olivier Tilloy (osomon) on 2015-04-30

Changed in webbrowser-app:
importance:	Undecided → High
status:	New → Confirmed

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-04-30:

#2

The problem lies in the selection mechanism not taking into account the current scale factor.

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-04-30:

#3

Unfortunately oxide doesn’t expose the current page scale factor.

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-04-30:

#4

Note that the device scale factor is exposed in the DOM as document.defaultView.devicePixelRatio, and it’s already being taken into account by the selection mechanism, but we also need the current page scale factor, which isn’t exposed anywhere.

Olivier Tilloy (osomon) on 2015-06-08

Changed in webbrowser-app (Ubuntu RTM):
status:	New → Confirmed
Changed in webbrowser-app (Ubuntu):
importance:	Undecided → Medium
Changed in webbrowser-app (Ubuntu RTM):
importance:	Undecided → Medium
Changed in webbrowser-app (Ubuntu):
importance:	Medium → High
Changed in webbrowser-app (Ubuntu RTM):
importance:	Medium → High
no longer affects:	webbrowser-app

Revision history for this message

Olivier Tilloy (osomon) wrote on 2015-07-30:

#5

It looks like my previous analysis was wrong: the offset isn’t due to the page scale factor, it’s due to the locationBarController’s height and offset not being taken into account. This can be fixed without an additional API in oxide.

Changed in webbrowser-app (Ubuntu):
assignee:	nobody → Olivier Tilloy (osomon)
status:	Confirmed → In Progress
Changed in oxide:
status:	New → Invalid

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2015-08-31:

#6

Download full text (14.5 KiB)

This bug was fixed in the package webbrowser-app 0.23+15.04.20150827.3-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

webbrowser-app (0.23+15.04.20150827.3-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Use the contextMenu API new in oxide 1.8. Update the visuals for the
    context menu in narrow and wide form factors. Add text editing
    commands to the context menu. Add unit and autopilot tests for the
    context menu features. This bumps the runtime dependency of webapp-
    container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-
    qmlplugin to 1.8. This also removes the qtdeclarative5-ubuntu-web-
    plugin-assets binary package, which contained only one PNG asset
    which is not used anywhere any longer. (LP: #1477310, #1477315,
    #1471181, #1264493, #1487090, #1326070, #1477309, #1450430,
    #1438046)

webbrowser-app (0.23+15.10.20150820-0ubuntu1) wily; urgency=medium

[ Alexandre Abreu ]
* Fix webapp name logic (LP: #1473472)

  [ Arthur Mello ]
  * Add support for removing history entries with delete key in
    HistoryViewWide (LP: #1484562)

[ CI Train Bot ]
* New rebuild forced.

  [ Olivier Tilloy ]
  * Remove an old workaround for an issue that was fixed since then in
    the content hub and that caused the file picker to accept the
    selected file twice.

  [ Ugo Riboni ]
  * Merge two url utility files into one, since they had no reason for
    being separate. Add unit tests for some of the functions that had
    none.

webbrowser-app (0.23+15.10.20150817-0ubuntu1) wily; urgency=medium

  [ Arthur Mello ]
  * Make sure to set the historyModel to the HistoryView component when
    browser wide property changes (LP: #1484555)
  * Wait for OptionSelector's collapsing transition to finish (LP:
    #1484175)

  [ Colin Watson ]
  * Fix versioned dependencies on qtdeclarative5-ubuntu-ui-toolkit-
    plugin to allow qtdeclarative5-ubuntu-ui-toolkit-plugin-gles.

webbrowser-app (0.23+15.10.20150814-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Ugo Riboni ]
  * Delay the exit from fullscreen mode until focus remains lost for a
    certain amount of time. (LP: #1477308)
  * Disable find in page when the new tab view is active. (LP: #1483847)

webbrowser-app (0.23+15.10.20150813.1-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
* New rebuild forced.

  [ Olivier Tilloy ]
  * Remove strong typing of the contextualActions and selectionActions
    properties. This would cause issues if an app imported Ubuntu.Web
    along with Ubuntu.Components < 1.3 and overrode one of these
    properties, because the webview expected an ActionList 1.3, and
    would get an earlier version. (LP: #1484437)
  * Update translation template.

webbrowser-app (0.23+15.10.20150812.1-0ubuntu1) wily; urgency=medium

  [ Arthur Mello ]
  * Wide screen versions of the history view and new tab view, per
    design specification. This adds a build dependency on qml-module-qt-
    labs-settings (for unit tests). (LP: #1351157, #1481647)

[ CI Train Bot ]...

This bug was fixed in the package webbrowser-app 0.23+15.04.20150827.3-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

webbrowser-app (0.23+15.04.20150827.3-0ubuntu1) vivid; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

[ Olivier Tilloy ]
  * Use the contextMenu API new in oxide 1.8. Update the visuals for the
    context menu in narrow and wide form factors. Add text editing
    commands to the context menu. Add unit and autopilot tests for the
    context menu features. This bumps the runtime dependency of webapp-
    container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-
    qmlplugin to 1.8. This also removes the qtdeclarative5-ubuntu-web-
    plugin-assets binary package, which contained only one PNG asset
    which is not used anywhere any longer. (LP: #1477310, #1477315,
    #1471181, #1264493, #1487090, #1326070, #1477309, #1450430,
    #1438046)

webbrowser-app (0.23+15.10.20150820-0ubuntu1) wily; urgency=medium

[ Alexandre Abreu ]
  * Fix webapp name logic (LP: #1473472)

[ Arthur Mello ]
  * Add support for removing history entries with delete key in
    HistoryViewWide (LP: #1484562)

[ CI Train Bot ]
  * New rebuild forced.

[ Olivier Tilloy ]
  * Remove an old workaround for an issue that was fixed since then in
    the content hub and that caused the file picker to accept the
    selected file twice.

[ Ugo Riboni ]
  * Merge two url utility files into one, since they had no reason for
    being separate. Add unit tests for some of the functions that had
    none.

webbrowser-app (0.23+15.10.20150817-0ubuntu1) wily; urgency=medium

[ Arthur Mello ]
  * Make sure to set the historyModel to the HistoryView component when
    browser wide property changes (LP: #1484555)
  * Wait for OptionSelector's collapsing transition to finish (LP:
    #1484175)

[ Colin Watson ]
  * Fix versioned dependencies on qtdeclarative5-ubuntu-ui-toolkit-
    plugin to allow qtdeclarative5-ubuntu-ui-toolkit-plugin-gles.

webbrowser-app (0.23+15.10.20150814-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

[ Ugo Riboni ]
  * Delay the exit from fullscreen mode until focus remains lost for a
    certain amount of time. (LP: #1477308)
  * Disable find in page when the new tab view is active. (LP: #1483847)

webbrowser-app (0.23+15.10.20150813.1-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.

[ Olivier Tilloy ]
  * Remove strong typing of the contextualActions and selectionActions
    properties. This would cause issues if an app imported Ubuntu.Web
    along with Ubuntu.Components < 1.3 and overrode one of these
    properties, because the webview expected an ActionList 1.3, and
    would get an earlier version. (LP: #1484437)
  * Update translation template.

webbrowser-app (0.23+15.10.20150812.1-0ubuntu1) wily; urgency=medium

[ Arthur Mello ]
  * Wide screen versions of the history view and new tab view, per
    design specification. This adds a build dependency on qml-module-qt-
    labs-settings (for unit tests). (LP: #1351157, #1481647)

[ CI Train Bot ]
  * New rebuild forced.

[ Olivier Tilloy ]
  * Update translation template.
  * Wide screen versions of the history view and new tab view, per
    design specification. This adds a build dependency on qml-module-qt-
    labs-settings (for unit tests). (LP: #1351157, #1481647)

[ Ugo Riboni ]
  * Wide screen versions of the history view and new tab view, per
    design specification. This adds a build dependency on qml-module-qt-
    labs-settings (for unit tests). (LP: #1351157, #1481647)

webbrowser-app (0.23+15.10.20150811-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.

[ Olivier Tilloy ]
  * Drop old names for QML dependencies. Original patch by Robert
    Ancell.
  * Highlight matching terms in one pass. (LP: #1481206)
  * Implement the "Find in Page" feature. This bumps the runtime
    dependency on liboxideqt-qmlplugin to 1.8. (LP: #1312260)

[ Robert Ancell ]
  * Drop old names for QML dependencies. Original patch by Robert
    Ancell.

[ Ugo Riboni ]
  * Implement the "Find in Page" feature. This bumps the runtime
    dependency on liboxideqt-qmlplugin to 1.8. (LP: #1312260)

webbrowser-app (0.23+15.10.20150810-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * Resync trunk.

[ Olivier Tilloy ]
  * Update all imports of:  - Ubuntu.Components to 1.3  - QtQuick to 2.4
     - QtQuick.Window to 2.2 (LP: #1483279)
  * Update translation template.

webbrowser-app (0.23+15.10.20150729-0ubuntu2~gcc5.1) wily; urgency=medium

* No-change test rebuild for g++5 ABI transition

webbrowser-app (0.23+15.10.20150729-0ubuntu1) wily; urgency=medium

[ Olivier Tilloy ]
  * Ensure a value is always returned by BookmarksModel::addFolder(…).
  * Update icon, per UI specification. (LP: #1412732)
  * When clearing browsing data, confirm action with a dialog, to give
    the user a chance to cancel it. (LP: #1471747)

webbrowser-app (0.23+15.10.20150728-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * Resync trunk.

[ Olivier Tilloy ]
  * Fix narrowing conversion that makes the build fail with GCC 5. (LP:
    #1475621)

webbrowser-app (0.23+15.10.20150709.4-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.

[ Olivier Tilloy ]
  * Disable periodic session saving while incognito. The public session
    is unlikely to change significantly while browsing incognito.
  * Prefer target_link_libraries(…) with Qt5:: prefixed modules over
    qt5_use_modules, per documentation at http://doc.qt.io/qt-5/cmake-
    manual.html.
  * Speed up a bunch of autopilot tests by not requiring to input and
    validate a URL in the address bar.

webbrowser-app (0.23+15.10.20150709.3-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.

[ Olivier Tilloy ]
  * Desktop tabs for convergence. added:
    src/app/webbrowser/NavigationBar.qml src/app/webbrowser/TabsBar.qml
    src/app/webbrowser/assets/private-browsing-exit.svg
    src/app/webbrowser/assets/tab-active-center@18.png
    src/app/webbrowser/assets/tab-active-left@18.png
    src/app/webbrowser/assets/tab-active-right@18.png
    src/app/webbrowser/assets/tab-hovered-center@18.png
    src/app/webbrowser/assets/tab-hovered-left@18.png
    src/app/webbrowser/assets/tab-hovered-right@18.png
    src/app/webbrowser/assets/tab-inactive-center@18.png
    src/app/webbrowser/assets/tab-inactive-left@18.png
    src/app/webbrowser/assets/tab-inactive-right@18.png
    tests/unittests/qml/tst_TabsBar.qml

webbrowser-app (0.23+15.10.20150708-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

[ Olivier Tilloy ]
  * Display the full URL when focusing the address bar. (LP: #1472161)
  * Update translation template.

webbrowser-app (0.23+15.10.20150702.1-0ubuntu1) wily; urgency=medium

[ Arthur Mello ]
  * Implement bookmark folders (LP: #1351147, #1259247)

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

webbrowser-app (0.23+15.10.20150624-0ubuntu1) wily; urgency=medium

[ Alberto Mardegan ]
  * Show an error screen if the trust session could not be opened. (LP:
    #1441873)

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

[ Olivier Tilloy ]
  * Update translation template.

webbrowser-app (0.23+15.10.20150618-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.

[ Michael Terry ]
  * Fix spelling of OK in private browsing dialog.

[ Olivier Tilloy ]
  * Actually push URLs to the clipboard. For some reason setting the
    "text/url-list" mime type doesn’t seem to work (or other
    applications do not implement pasting this kind of data), but
    "text/plain" works well enough for this purpose. (LP: #1463435)
  * Do not honour fullscreen requests silently at the Ubuntu WebView
    level. Instead delegate that behaviour to the webview implementation
    used by the browser and the webapp container. (LP: #1464249)
  * Toggle application-level fullscreen when pressing F11. (LP:
    #1464333)

[ Ugo Riboni ]
  * Make the browser chrome usable on desktop by implementing common
    keyboard shortcuts and behaviors that users normally expect in such
    an app (LP: #1287361)

webbrowser-app (0.23+15.10.20150610-0ubuntu2) wily; urgency=medium

* No-change rebuild against Qt 5.4.2.

webbrowser-app (0.23+15.10.20150610-0ubuntu1) wily; urgency=medium

[ Alexandre Abreu ]
  * Ensure SAML requests are followed even if the app is interrupted and
    restarted. (LP: #1451432, #1452142)
  * Handle desktop download by forwarding to the default browser (LP:
    #1309657)

[ Olivier Tilloy ]
  * Update translation template.
  * Updated bzr ignore rules.

webbrowser-app (0.23+15.10.20150602-0ubuntu1) wily; urgency=medium

[ CI Train Bot ]
  * New rebuild forced.

[ Olivier Tilloy ]
  * Actually clear the network cache by deleting the correct set of
    files in the correct directory. (LP: #1459956)
  * Bump build dependency on liboxideqt-qmlplugin to 1.6 to fix unit
    tests.
  * Do not cache favicons on disk when browsing in private mode. (LP:
    #1458963)
  * Do not try to remove a file that doesn’t exist.
  * Pass plain strings to the worker script instead of RegExps. (LP:
    #1445673)
  * Remove the upstreamcomponents folder, and use components from the
    UITK instead. Add autopilot tests for the new tab view.
  * Update translation template.
  * Updated icon. (LP: #1457424)

[ Riccardo Padovani ]
  * New tab view refactoring. (LP: #1371248, #1444023, #1351157,
    #1389605, #1442190)
  * New tab view refactoring. (LP: #1371248, #1444023, #1351157,
    #1389605, #1442190)

webbrowser-app (0.23+15.04.20150522.1-0ubuntu1) vivid; urgency=medium

[ Arthur Mello ]
  * Implement private browsing mode per design specification. (LP:
    #1351179, #1457925, #1457958)

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

[ Olivier Tilloy ]
  * Add Qwant to the default list of search engines. added:
    src/app/webbrowser/searchengines/qwant.xml
  * Add missing import statement. (LP: #1457060)
  * Delay hiding the tab contents to give it an opportunity to grab an
    up-to-date capture. Improve the tab switching animation to not
    flicker and jump around that much. (LP: #1452998)
  * Ensure the search engine delegates do not overlap with the settings
    header. (LP: #1455399)
  * Fix a flaky autopilot test. On a mobile device with network access,
    the URL (http://en.wikipedia.org/wiki/Linux) might be rewritten to
    https://en.m.wikipedia.org/wiki/Linux, thus making the test racy
    depending on when the check on the webview’s URL is performed. (LP:
    #1456885)
  * Make use of the WebContext.maxCacheSizeHint property, introduced in
    Oxide 1.6. This bumps the dependency of qtdeclarative5-ubuntu-web-
    plugin on liboxideqt-qmlplugin to 1.6. (LP: #1277659)
  * Remove a number of useless calls to QTest::qWait() in unit tests,
    thus making them significantly faster to run.
  * When opening a new blank tab, always clear the address bar. (LP:
    #1456199)

webbrowser-app (0.23+15.04.20150515-0ubuntu1) vivid; urgency=medium

[ CI Train Bot ]
  * Resync trunk.

[ Olivier Tilloy ]
  * Change the homepage in tests so that the domain name doesn’t contain
    a dot, to work around https://launchpad.net/bugs/1108742. (LP:
    #1108742)
  * Delay showing the fullscreen hint to prevent it from jumping up
    while the webview is being resized. (LP: #1454097)
  * Look for custom search engines description files in several
    locations. This adds a build dependency on qml-module-qt-labs-
    folderlistmodel, to run unit tests at package construction time.
    (LP: #1455207)
  * Use checkboxes instead of switches for verb phrases, per design
    guidance. (LP: #1442851)

webbrowser-app (0.23+15.04.20150512-0ubuntu1) vivid; urgency=medium

[ CI Train Bot ]
  * Resync trunk.

[ Leo Arias ]
  * Fix the base class used when launching the app in autopilot tests.

[ Leonardo Arias Fonseca ]
  * Fix the base class used when launching the app in autopilot tests.

[ Olivier Tilloy ]
  * Also set XDG_CONFIG_HOME (needed for tests not to override user-
    defined settings).
  * Update translation template.
  * Use the new Oxide APIs to better control visibility of the chrome.
    This bumps the runtime dependency on liboxideqt-qmlplugin to 1.7.
    (LP: #1441064, #1453908)

[ Riccardo Padovani ]
  * Add support for data: URIs in the address bar, and remove length
    limitation for TLDs. (LP: #1377953, #1441281, #1450154)
  * Add support for data: URIs in the address bar, and remove length
    limitation for TLDs. (LP: #1377953, #1441281, #1450154)

[ Ugo Riboni ]
  * Add suggestions from search engines in the suggestions list. (LP:
    #1351151)

webbrowser-app (0.23+15.04.20150506-0ubuntu1) vivid; urgency=medium

[ Arthur Mello ]
  * Change asset for the bottom edge hint. Add text with open tabs
    count.

[ CI Train Bot ]
  * Resync trunk. added: po/ia.po

[ Leo Arias ]
  * Fixed flake8 error. (LP: #1444170)

[ Leonardo Arias Fonseca ]
  * Fixed flake8 error. (LP: #1444170)

[ Olivier Tilloy ]
  * Remove deprecated compatibility code.
  * Run autopilot tests in a temporary profile directory, to avoid
    polluting the current user’s profile. (LP: #1448838)
  * Save the session periodically to mitigate the situation where
    multiple new tabs had been created when the browser crashes. (LP:
    #1449761)
  * Visual feedback for pressed state of chrome buttons and drawer menu
    entries. (LP: #1448336)

webbrowser-app (0.23+15.04.20150430.1-0ubuntu1) vivid; urgency=medium

[ Alexandre Abreu ]
  * Add multi-window support for webapps (LP: #1411722)

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

[ Olivier Tilloy ]
  * Update translation template.

webbrowser-app (0.23+15.04.20150422.1-0ubuntu1) vivid; urgency=medium

[ Alexandre Abreu ]
  * Add missing reload button from the webapp container as specified in
    the design document.

[ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

[ Ken VanDine ]
  * added ShareLink to contextualActions

[ Leo Arias ]
  * In the autopilot tests, removed the extra focus step to write a URL.
    (LP: #1441551)

[ Olivier Tilloy ]
  * Always exit fullscreen mode when the application becomes inactive.
    (LP: #1331475)
  * Recognize about:blank as a valid URL. (LP: #1444139)
  * Save the updated homepage when pressing return. (LP: #1441874)

[ Ugo Riboni ]
  * Include bookmark results in the suggestions list (LP: #1351177)

-- CI Train Bot <ci-train-bot@canonical.com>  Thu, 27 Aug 2015 14:02:08 +0000

Changed in webbrowser-app (Ubuntu RTM):
status:	Confirmed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-08-31:

#7

This bug was fixed in the package webbrowser-app - 0.23+15.10.20150827.3-0ubuntu1

---------------
webbrowser-app (0.23+15.10.20150827.3-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Use the contextMenu API new in oxide 1.8. Update the visuals for the
    context menu in narrow and wide form factors. Add text editing
    commands to the context menu. Add unit and autopilot tests for the
    context menu features. This bumps the runtime dependency of webapp-
    container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-
    qmlplugin to 1.8. This also removes the qtdeclarative5-ubuntu-web-
    plugin-assets binary package, which contained only one PNG asset
    which is not used anywhere any longer. (LP: #1477310, #1477315,
    #1471181, #1264493, #1487090, #1326070, #1477309, #1450430,
    #1438046)

-- CI Train Bot <email address hidden> Thu, 27 Aug 2015 14:02:08 +0000

Changed in webbrowser-app (Ubuntu):
status:	In Progress → Fix Released

Pat McGowan (pat-mcgowan) on 2015-09-03

Changed in canonical-devices-system-image:
status:	New → Fix Committed
assignee:	nobody → Bill Filler (bfiller)
importance:	Undecided → High
milestone:	none → ww40-2015

Pat McGowan (pat-mcgowan) on 2015-10-19

Changed in canonical-devices-system-image:
status:	Fix Committed → Fix Released

Ubuntu
webbrowser-app package

Text selection box drawn in wrong place

Bug Description

Related branches

Other bug subscribers

Bug attachments

Remote bug watches

	Status	Importance	Assigned to	Milestone
Canonical System Image	Fix Released	High	Bill Filler	Canonical System Image ww40-2015 "ota7"
Oxide	Invalid	Undecided	Unassigned
webbrowser-app (Ubuntu)	Fix Released	High	Olivier Tilloy
webbrowser-app (Ubuntu RTM)	Fix Released	High	Unassigned

Ubuntuwebbrowser-app package

Text selection box drawn in wrong place

Bug Description

Related branches

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
webbrowser-app package