Murano

AgentListener doesn't stop after GC cleanup

Bug #1449500 reported by Stan Lagun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Critical
Stan Lagun
Murano 2015.1.0 "kilo"
Kilo
Fix Released
Critical
Stan Lagun
Murano 2015.1.0 "kilo"
Liberty
Fix Released
Critical
Stan Lagun
Murano 1.0.1

Bug Description

Any application/class may have "destroy" method that is being called during garbage collection. If such method needs to send execution plan to murano-agent (for example to uninstall something) AgentListener will be started and results queue in RabbitMQ will be consumed. After GC phase there is a deployment phase and it typically requires to also send execution plans. Because GC runs on ObjectCopy and deployment on Objects 2 different instances if AgentListener will be created consuming the same queue and stealing messages from each other.

Victor Ryzhenkin (vryzhenkin)
Changed in murano:
status: New → Confirmed
Victor Ryzhenkin (vryzhenkin)
Changed in murano:
milestone: none → kilo-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/178717

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/kilo)

Reviewed: https://review.openstack.org/178717
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=a79955709d4a628ef7f78fec214acd2742c69aae
Submitter: Jenkins
Branch: stable/kilo

commit a79955709d4a628ef7f78fec214acd2742c69aae
Author: Stan Lagun <email address hidden>
Date: Wed Apr 29 18:08:51 2015 +0300

    Execute pre/post deployment hooks on GC

    Currently pre/post deployment are invoked only for
    deployment (actions). Those hooks are used to stop
    AgentListener. But they were not executed for GC
    phase that could also start AgentListener. As a result
    we could get 2 AgentListeners running and stealing
    messages from each other

    Change-Id: If96db92e38f067bfed72cfc4a3d5619de2f0fad3
    Closes-Bug: #1449500

Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/179533

Serg Melikyan (smelikyan)
Changed in murano:
milestone: kilo-rc2 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/179533
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=afb730e82dd7e9bac89fa2e765c8a7968d2b7844
Submitter: Jenkins
Branch: master

commit afb730e82dd7e9bac89fa2e765c8a7968d2b7844
Author: Stan Lagun <email address hidden>
Date: Wed Apr 29 18:08:51 2015 +0300

    Execute pre/post deployment hooks on GC

    Currently pre/post deployment are invoked only for
    deployment (actions). Those hooks are used to stop
    AgentListener. But they were not executed for GC
    phase that could also start AgentListener. As a result
    we could get 2 AgentListeners running and stealing
    messages from each other

    Change-Id: If96db92e38f067bfed72cfc4a3d5619de2f0fad3
    Closes-Bug: #1449500
    (cherry picked from commit a79955709d4a628ef7f78fec214acd2742c69aae)

Kirill Zaitsev (kzaitsev)
tags: added: juno-backport-potential
Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.