Murano

API doesn't honour owned flag for admins.

Bug #1448226 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
High
Kirill Zaitsev
Murano 2015.1.0 "kilo"
Kilo
Fix Released
High
Kirill Zaitsev
Murano 2015.1.0 "kilo"
Liberty
Fix Released
High
Kirill Zaitsev
Murano 1.0.1

Bug Description

Packages API doesn't honour owned flag for admin requests.

To reproduce call packages.list api owned=True wile authenticated as admin.

NOTE: Straightforward fix would cause problems in murano-dashboard, due to the fact, that API currently doesn't distinguish between catalog and manage(Package-definitions) calls.

Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
Revision history for this message
Serg Melikyan (smelikyan) wrote :

Hi Kirill,

I would like to hear more about use facing issues of this behavior

Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

It's impossible for admin user to request all the packages, that he or she owns. Current API implementation would always return public packages from other tenants for admin. We do not hav a user-facing switch not in the cli nor in the web-UI, but this is needed to implement automatic package deletion in python-muranoclient.

corresponding bug in client is https://bugs.launchpad.net/python-muranoclient/+bug/1448135

no longer affects: python-muranoclient
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177796

Changed in murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/177869

Serg Melikyan (smelikyan)
Changed in murano:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/178305

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on murano (stable/kilo)

Change abandoned by Kirill Zaitsev (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/178305

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/177796
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=58819afbec81dbe81017a216c1c9b27cac34f545
Submitter: Jenkins
Branch: master

commit 58819afbec81dbe81017a216c1c9b27cac34f545
Author: Kirill Zaitsev <email address hidden>
Date: Mon Apr 27 17:32:13 2015 +0300

    Streamline and simplify package filtering api

    Introduce catalogue parameter to allow distinguishing between catalogue
    of applications (packages that one can deploy) and managable-apps
    (packages that one can edit).
    Streamline include_disabled filtering.
    Allow filtering out your own packages for admin requests.

    Change-Id: I19a90b26abebe0833878c560169d6569a9d7421e
    Partial-Bug: #1448226
    Relates-Bug: #1448135

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/178370

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano-dashboard (stable/kilo)

Related fix proposed to branch: stable/kilo
Review: https://review.openstack.org/178375

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/kilo)

Reviewed: https://review.openstack.org/178370
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=e76c0657e4b5febc18709ee6c592a928a25e1fcd
Submitter: Jenkins
Branch: stable/kilo

commit e76c0657e4b5febc18709ee6c592a928a25e1fcd
Author: Kirill Zaitsev <email address hidden>
Date: Mon Apr 27 17:32:13 2015 +0300

    Streamline and simplify package filtering api

    Introduce catalogue parameter to allow distinguishing between catalogue
    of applications (packages that one can deploy) and managable-apps
    (packages that one can edit).
    Streamline include_disabled filtering.
    Allow filtering out your own packages for admin requests.

    Change-Id: Ica031058d963246ff4d76e52cfc8b8b44d207c9a
    Partial-Bug: #1448226
    Relates-Bug: #1448135

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (stable/kilo)

Reviewed: https://review.openstack.org/178375
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=f897d5b4f23bf1d19e013ab1372b7225ed589a0f
Submitter: Jenkins
Branch: stable/kilo

commit f897d5b4f23bf1d19e013ab1372b7225ed589a0f
Author: Kirill Zaitsev <email address hidden>
Date: Mon Apr 27 19:38:23 2015 +0300

    Take advantage of better API filtering catalog filtering

    * Removed client-side filtering, since API is now distincts
    between catalog and manage requests
    * Do not use owned=True for manage requests, since this is now the default
    API behaviour.
    * Simplify marker choice for next/prev links, since we reverse packages in
    case of sort_dir='desc' to preserve visual order of apps.

    Change-Id: I0136307e09695f49663779570cf23560521d9585
    Depends-On: Ica031058d963246ff4d76e52cfc8b8b44d207c9a
    Related-Bug: #1448226

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/177869
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=f80519a9926e9067a1b8606a550f07fa919fc9d6
Submitter: Jenkins
Branch: master

commit f80519a9926e9067a1b8606a550f07fa919fc9d6
Author: Kirill Zaitsev <email address hidden>
Date: Mon Apr 27 19:38:23 2015 +0300

    Take advantage of better API filtering catalog filtering

    * Removed client-side filtering, since API is now distincts
    between catalog and manage requests
    * Do not use owned=True for manage requests, since this is now the default
    API behaviour.
    * Simplify marker choice for next/prev links, since we reverse packages in
    case of sort_dir='desc' to preserve visual order of apps.

    Change-Id: I24b7a2b3f1f7fa0d093d336beb8430a05e56bdaf
    Related-Bug: #1448226

Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
Serg Melikyan (smelikyan)
Changed in murano:
milestone: kilo-rc2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.