Murano

Warn users about images with the same name

Bug #1443936 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Critical
Kirill Zaitsev
Murano 1.0.1

Bug Description

In case a package get's updated — it might contain a new image with the same name, yet different hash. In that case importing the package would cause image to be downloaded, which would result in 2 different images with the same name and different hashes.

Due to the fact, that murano-apps currently hardcodes image names — this causes problems during deployments.

In any case it's worth alerting the user about the fact, that image with specified name, yet different hash already exists in glance, and either refuse to upload the image or ask the user on what he or she should do with the image.

Ekaterina Chernova (efedorova)
Changed in murano:
milestone: none → kilo-rc2
importance: Undecided → High
status: New → Confirmed
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: kilo-rc2 → liberty-1
Victor Ryzhenkin (vryzhenkin)
Changed in murano:
importance: High → Critical
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/181369

Changed in murano:
assignee: nobody → Ekaterina Chernova (efedorova)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to murano (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/181464

OpenStack Infra (hudson-openstack)
Changed in murano:
assignee: Ekaterina Chernova (efedorova) → Kirill Zaitsev (kzaitsev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-muranoclient (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/183150

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (stable/kilo)

Reviewed: https://review.openstack.org/183150
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=8c0105276493bdb29d5f1b3ec9964121db8f76c8
Submitter: Jenkins
Branch: stable/kilo

commit 8c0105276493bdb29d5f1b3ec9964121db8f76c8
Author: Ekaterina Chernova <email address hidden>
Date: Fri May 8 14:43:44 2015 +0300

    Remove hash check during image upload

    There were situations, when image was upload twice automatically,
    because it was updated and it's hash changed.
    But since these images have the same name and some of our applications
    currently rely on image name, when constructing heat template it caused
    problems in heat, as it could not resolve this situation,
    while deploying template, generated by Murano.

    Change-Id: Ib8f86f4934b2420d3c1c7e952dcbb47bcc9ab81c
    Closes-Bug: #1443936

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/181369
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=af0a55cb81a595eb6912fadb29cfc7dcda85b579
Submitter: Jenkins
Branch: master

commit af0a55cb81a595eb6912fadb29cfc7dcda85b579
Author: Ekaterina Chernova <email address hidden>
Date: Fri May 8 14:43:44 2015 +0300

    Remove hash check during image upload

    There were situations, when image was upload twice automatically,
    because it was updated and it's hash changed.
    But since these images have the same name and some of our applications
    currently rely on image name, when constructing heat template it caused
    problems in heat, as it could not resolve this situation,
    while deploying template, generated by Murano.

    Change-Id: Ib8f86f4934b2420d3c1c7e952dcbb47bcc9ab81c
    Closes-Bug: #1443936

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on murano (master)

Change abandoned by Ekaterina Chernova (<email address hidden>) on branch: master
Review: https://review.openstack.org/181464
Reason: Replaced with https://review.openstack.org/#/c/184805/

Kirill Zaitsev (kzaitsev)
tags: added: kilo-backport-potential
Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
Serg Melikyan (smelikyan)
Changed in murano:
milestone: liberty-1 → 1.0.0
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: 1.0.0 → 1.0.1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/python-muranoclient 0.5.10

This issue was fixed in the openstack/python-muranoclient 0.5.10 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/python-muranoclient 0.5.10 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.