neutron

test_ensure_dir_*_exist fails randomly

Bug #1441347 reported by Armando Migliaccio
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Armando Migliaccio
neutron 2015.1.0 "kilo"

Bug Description

Tests fail with:

ft1.579: neutron.tests.unit.agent.linux.test_utils.TestBaseOSUtils.test_ensure_dir_exist_StringException: Empty attachments:
  pythonlogging:''
  pythonlogging:'neutron.api.extensions'
  stderr
  stdout

Traceback (most recent call last):
  File "/home/jenkins/workspace/gate-neutron-python27/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 1201, in patched
    return func(*args, **keywargs)
  File "neutron/tests/unit/agent/linux/test_utils.py", line 236, in test_ensure_dir_exist
    isdir.assert_called_once_with('/the')
  File "/home/jenkins/workspace/gate-neutron-python27/.tox/py27/local/lib/python2.7/site-packages/mock.py", line 845, in assert_called_once_with
    raise AssertionError(msg)
AssertionError: Expected to be called once. Called 0 times.

The logstash query:

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiaW4gdGVzdF9lbnN1cmVfZGlyX25vdF9leGlzdFwiIiwiZmllbGRzIjpbXSwib2Zmc2V0IjowLCJ0aW1lZnJhbWUiOiI2MDQ4MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDI4NDM5NTU2MzA4fQ==

See original description
Armando Migliaccio (armando-migliaccio)
Changed in neutron:
status: New → Confirmed
Revision history for this message
Kyle Mestery (mestery) wrote :

Ignore my link in comment #1, it's not related and is a separate issue.

Changed in neutron:
importance: Undecided → High
milestone: none → kilo-rc1
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiaW4gdGVzdF9lbnN1cmVfZGlyX2V4aXN0XCIiLCJmaWVsZHMiOltdLCJvZmZzZXQiOjAsInRpbWVmcmFtZSI6IjYwNDgwMCIsImdyYXBobW9kZSI6ImNvdW50IiwidGltZSI6eyJmcm9tIjoiMjAxNS0wNC0wN1QwNTo1MTo1NiswMDowMCIsInRvIjoiMjAxNS0wNC0wN1QwNTo1NDo0MyswMDowMCIsInVzZXJfaW50ZXJ2YWwiOjB9LCJzdGFtcCI6MTQyODQ0MTEwNjY1Nn0=

summary: - test_ensure_dir_not_exist fails randomly
+ test_ensure_dir_*_exist fails randomly
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

Latest logstash captures random failures for another test.

Kyle Mestery (mestery)
Changed in neutron:
assignee: nobody → Armando Migliaccio (armando-migliaccio)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171433

Armando Migliaccio (armando-migliaccio)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/171433
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=31631e82bbf974c50fb913dafe0ad86e2c0e6a8b
Submitter: Jenkins
Branch: master

commit 31631e82bbf974c50fb913dafe0ad86e2c0e6a8b
Author: armando-migliaccio <email address hidden>
Date: Tue Apr 7 15:37:59 2015 -0700

    Fix intermittent UT failures in test_utils

    Change eba4c2941ee introduced these tests. However they are not that useful as they
    simply mimick the code, without really ensuring that the behavior is expected, so
    they provide negative value ([1]), plus, they fail randomly.

    This patch removes them in favor of a more useful functional check.

    [1] http://googletesting.blogspot.com/2015/01/testing-on-toilet-change-detector-tests.html

    Closes-bug: #1441347

    Change-Id: I8a321995295deef7f6d30be303486be491e2771f

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: kilo-rc1 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (neutron-pecan)

Fix proposed to branch: neutron-pecan
Review: https://review.openstack.org/185072

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.