Mir

[testsfail] CI failure in ClientLibraryErrorsDeathTest.creating_surface_synchronosly_on_malconstructed_connection_is_fatal

Bug #1438702 reported by Alan Griffiths
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Medium
Alan Griffiths
Mir 0.13.0
mir (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

https://code.launchpad.net/~kdub/mir/no-display-attribs/+merge/253853
https://code.launchpad.net/~alan-griffiths/mir/death-to-NullWindowManager/+merge/254713
https://code.launchpad.net/~alan-griffiths/mir/proving-still-uses-DefaultWindowManager/+merge/254728

Three different MPs with mir-mediumtests-runner-mako failure:

[ RUN ] ClientLibraryErrorsDeathTest.creating_surface_synchronosly_on_malconstructed_connection_is_fatal

[WARNING] /usr/src/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads.
unknown file: Failure
C++ exception with description "stop_server() failed to stop server" thrown in TearDown().
Build timed out (after 60 minutes). Marking the build as failed.

Related branches

lp://staging/~alan-griffiths/mir/workaround-1438702
Alberto Aguirre (community): Approve
Andreas Pokorny (community): Approve
Kevin DuBois (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 18 lines (+5/-1)
1 file modified
tests/acceptance-tests/test_client_library_errors.cpp (+5/-1)
lp://staging/ubuntu/wily-proposed/mir
Alan Griffiths (alan-griffiths)
Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
status: New → Confirmed
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Got it to happen locally (clang on arm64):

(gdb) info threads
  Id Target Id Frame
  7 Thread 0x7f11e661b700 (LWP 27521) ".mir_acceptance" 0x00007f11ea4b08ed in pthread_join (threadid=139714606655952,
    thread_return=0x0) at pthread_join.c:90
  6 Thread 0x7f11e5ad2700 (LWP 27529) "Mir/Snapshot" pthread_cond_wait@@GLIBC_2.3.2 ()
    at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  5 Thread 0x7f11d7fff700 (LWP 27532) "Mir/IPC" 0x00007f11ea1e54f3 in epoll_wait ()
    at ../sysdeps/unix/syscall-template.S:81
  4 Thread 0x7f11e50a8700 (LWP 27533) "Mir/IPC" pthread_cond_wait@@GLIBC_2.3.2 ()
    at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  3 Thread 0x7f11e48a7700 (LWP 27534) "Mir/Comp" pthread_cond_wait@@GLIBC_2.3.2 ()
    at ../sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.S:185
  2 Thread 0x7f11d77fe700 (LWP 27535) "Mir/Input" 0x00007f11ea1e54f3 in epoll_wait ()
    at ../sysdeps/unix/syscall-template.S:81
* 1 Thread 0x7f11ee98d840 (LWP 27438) ".mir_acceptance" 0x00007f11ea4b08ed in pthread_join (threadid=139714856335824,
    thread_return=0x0) at pthread_join.c:90

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I'm not sure exactly what's going on - but one of the input managers (I was surprised to discover two) isn't closing down properly.

As these tests don't actually rely on input I'll MP disabling it as a workaround and log another bug.

Changed in mir:
status: Confirmed → In Progress
Daniel van Vugt (vanvugt)
Changed in mir:
milestone: none → 0.13.0
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I think we're leaking something in recent input changes. That would also explain bug 1438160.

Revision history for this message
Andreas Pokorny (andreas-pokorny) wrote :

@alan: Yes until the next mp lands there are two input managers. Both start, and one does nothing.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.13.0

Changed in mir:
status: In Progress → Fix Committed
Daniel van Vugt (vanvugt)
Changed in mir:
importance: Undecided → Medium
Alan Griffiths (alan-griffiths)
Changed in mir:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000

Changed in mir (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.