OpenStack Compute (nova)

Hyper-V: Compute Driver doesn't start if there are instances with no VM Notes

Bug #1438638 reported by Claudiu Belu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Claudiu Belu
OpenStack Compute (nova) 12.0.0 "liberty"
Juno
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2014.2.4
Kilo
Fix Released
Undecided
Unassigned
OpenStack Compute (nova) 2015.1.1

Bug Description

The Nova Hyper-V Compute Driver cannot start if there are instances with Notes = None. This can be caused by the users, by manually altering the VM Notes or if there are VMs created by the users.

Logs: http://paste.openstack.org/show/197681/

Claudiu Belu (cbelu)
Changed in nova:
assignee: nobody → Claudiu Belu (cbelu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/169267

Changed in nova:
status: New → In Progress
Davanum Srinivas (DIMS) (dims-v)
Changed in nova:
importance: Undecided → Low
Matt Riedemann (mriedem)
tags: added: hyper-v
Changed in nova:
importance: Low → Medium
tags: added: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/169267
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2c3da5462684c930436c9e91cb1e893e0936a331
Submitter: Jenkins
Branch: master

commit 2c3da5462684c930436c9e91cb1e893e0936a331
Author: Claudiu Belu <email address hidden>
Date: Tue Mar 31 14:01:37 2015 +0300

    Hyper-V: checks for existent Notes in list_instance_notes

    If there are VMs with Notes = None, the Hyper-V Driver cannot
    start, as it tries to iterate over None, which results in an
    exception.

    This commit adds a check if the Notes exist, before iterating over
    them.

    Closes-Bug: #1438638

    Change-Id: Icebdc03d7249fdf903b94b2f61f4891f5c9d6e50

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/176249

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/176435

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/kilo)

Reviewed: https://review.openstack.org/176435
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=d8a470d6808f0bc09b82a8f73bc7f30d437ee0cf
Submitter: Jenkins
Branch: stable/kilo

commit d8a470d6808f0bc09b82a8f73bc7f30d437ee0cf
Author: Claudiu Belu <email address hidden>
Date: Tue Mar 31 14:01:37 2015 +0300

    Hyper-V: checks for existent Notes in list_instance_notes

    If there are VMs with Notes = None, the Hyper-V Driver cannot
    start, as it tries to iterate over None, which results in an
    exception.

    This commit adds a check if the Notes exist, before iterating over
    them.

    Closes-Bug: #1438638

    (cherry picked from commit 2c3da5462684c930436c9e91cb1e893e0936a331)

    Change-Id: Icebdc03d7249fdf903b94b2f61f4891f5c9d6e50

tags: added: in-stable-kilo
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/juno)

Reviewed: https://review.openstack.org/176249
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8718e51acba69e37eeddcc41fead334acfffef95
Submitter: Jenkins
Branch: stable/juno

commit 8718e51acba69e37eeddcc41fead334acfffef95
Author: Claudiu Belu <email address hidden>
Date: Tue Mar 31 14:01:37 2015 +0300

    Hyper-V: checks for existent Notes in list_instance_notes

    If there are VMs with Notes = None, the Hyper-V Driver cannot
    start, as it tries to iterate over None, which results in an
    exception.

    This commit adds a check if the Notes exist, before iterating over
    them.

    Closes-Bug: #1438638

    Conflicts:
     nova/tests/unit/virt/hyperv/test_vmutils.py
     nova/tests/unit/virt/hyperv/test_vmutilsv2.py

    (cherry picked from commit 2c3da5462684c930436c9e91cb1e893e0936a331)

    Change-Id: Icebdc03d7249fdf903b94b2f61f4891f5c9d6e50

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-1 → 12.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.