There is a wrong variable format used in msg of ilo function _update_capabilities

Bug #1438041 reported by Kan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Kan

Bug Description

node_capabilities = node.properties.get('capabilities')
if node_capabilities:
 try:
  cap_dict = dict(x.split(':', 1)
      for x in node_capabilities.split(','))
 except ValueError:
  # Capabilities can be filled by operator. ValueError can
  # occur in malformed capabilities like:
  # properties/capabilities='boot_mode:bios,boot_option'.
  msg = (_("Node %(node)s has invalid capabilities string "
    "%(capabilities), unable to modify the node "
    "properties['capabilities'] string")
    % {'node': node.uuid, 'capabilities': node_capabilities})

The '%(capabilities)' should be '%(capabilities)s' in msg.

Kan (kansks)
description: updated
description: updated
Changed in ironic:
assignee: nobody → Kan (kansks)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168804

Changed in ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/168804
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=45a03946bf73f4e225119d94689289d37d181fb7
Submitter: Jenkins
Branch: master

commit 45a03946bf73f4e225119d94689289d37d181fb7
Author: Kan <email address hidden>
Date: Mon Mar 30 00:44:50 2015 -0700

    A wrong variable format used in msg of ilo:

    In function _update_capabilities:

    "%(capabilities), unable to modify the node "

    The '%(capabilities)' should be '%(capabilities)s'.

    Change-Id: Ieebb3286b0d32f291a9e8dc519218d35e7c52f43
    Closes-Bug: #1438041

Changed in ironic:
status: In Progress → Fix Committed
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Low
milestone: none → kilo-rc1
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.