Unsupported files silently do nothing
Bug #1437622 reported by
Cris Dywan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Document Viewer App |
Fix Released
|
High
|
Stefano Verzegnassi | ||
Bug Description
Through the content hub I can use the document viewer for a number of file types, including comic books or ODF documents. As I have no way of knowing what actually is supported (short of reading the source code) I tried several kinds of files and very confusingly they seem to be completely ignored. They don't show up in the list, they don't result in any error message, it's identical to opening the document viewer from the launcher without any file at all.
Related branches
lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/adv-import-handler
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Alan Pope 🍺🐧🐱 🦄 (community): Approve
-
Diff: 3642 lines (+847/-811)43 files modifiedpo/am.po (+9/-23)
po/ast.po (+9/-23)
po/br.po (+9/-23)
po/ca.po (+9/-23)
po/com.ubuntu.docviewer.pot (+42/-6)
po/cs.po (+9/-23)
po/da.po (+9/-23)
po/de.po (+9/-23)
po/el.po (+9/-23)
po/en_AU.po (+9/-23)
po/en_GB.po (+9/-23)
po/eo.po (+9/-23)
po/es.po (+9/-23)
po/eu.po (+9/-23)
po/fi.po (+9/-23)
po/fr.po (+46/-13)
po/gd.po (+10/-24)
po/gl.po (+10/-24)
po/hu.po (+10/-24)
po/it.po (+9/-23)
po/lo.po (+9/-23)
po/lv.po (+9/-23)
po/nb.po (+9/-23)
po/nl.po (+9/-23)
po/ny.po (+9/-23)
po/pa.po (+10/-24)
po/pl.po (+9/-23)
po/pt.po (+9/-23)
po/pt_BR.po (+9/-23)
po/ru.po (+9/-23)
po/sl.po (+9/-23)
po/tr.po (+9/-23)
po/uk.po (+9/-23)
po/zh_CN.po (+9/-23)
po/zh_TW.po (+9/-23)
src/app/content-communicator.cpp (+63/-25)
src/app/content-communicator.h (+3/-1)
src/app/qml/common/FileNotFoundDialog.qml (+1/-1)
src/app/qml/common/PickImportedDialog.qml (+50/-0)
src/app/qml/common/RejectedImportDialog.qml (+45/-0)
src/app/qml/common/Toast.qml (+82/-0)
src/app/qml/common/ToastWithAction.qml (+117/-0)
src/app/qml/ubuntu-docviewer-app.qml (+97/-2)
Revision history for this message
| Stefano Verzegnassi (verzegnassi-stefano) wrote | #1 |
| Changed in ubuntu-docviewer-app: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in ubuntu-docviewer-app: | |
| milestone: | none → 2015-04-09 |
| Changed in ubuntu-docviewer-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #2 |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-docviewer-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yes, this is actually a big issue.
We shouldn't import that document type that we don't support, and show a dialog that inform users of what's happening.
AFAIK, I've heard about some upcoming updates for content-hub which should allow to filter out the peers that don't support a specific file mime type. Dunno the ETA though.