Ironic

Stop console when changing node's driver

Bug #1436884 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Lucas Alvares Gomes
Ironic 2015.1.0 "kilo"

Bug Description

If the console is enabled for a node and we update it changing the driver, that console will continue to run and the new driver won't be able to stop it, either because it doesn't know how to stop or the new driver may not even have a console interface.

So we need to make sure that, if the node is changing the driver and the console is enabled we should stop it.

Lucas Alvares Gomes (lucasagomes)
Changed in ironic:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
milestone: none → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/168030

Changed in ironic:
status: New → In Progress
Lucas Alvares Gomes (lucasagomes)
Changed in ironic:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/168030
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=944845dfef17b38362a6051747388b1b3ba85c0e
Submitter: Jenkins
Branch: master

commit 944845dfef17b38362a6051747388b1b3ba85c0e
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Mar 27 15:05:05 2015 +0000

    Prevent updating the node's driver if console is enabled

    This patch is preventing a node from updating it's driver if the console
    is enabled. That's because the new driver won't be able to stop the
    console started by the previous one. In the future we might look at
    stopping the console instead of just failing to update the node, but
    since it requires some plumbing work just stopping the update seems good
    to prevent this bug from sneaking in the RC1 release.

    Closes-Bug: #1436884
    Change-Id: I1f8778142faaac608fd9eed4d0c40d0d372454db

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.