boot_mode is overwritten in node properties/capabilities when secure boot is requested for iLO drivers

Bug #1436791 reported by Shivanand Tendulker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Shivanand Tendulker

Bug Description

When deploy is requested for by setting instance_info/capabilities with secure_boot='true', the code oevrwrites the capabilities in the node/properties.

Steps to reproduce:-
$ ironic node-update $NODE remove properties
$ ironic node-update $NODE add instance_info/image_source=$UBUNTU_CLOUD_IMAGE instance_info/root_gb=5
$ ironic node-update $NODE add instance_info/capabilities='{"secure_boot":"true"}'
$ ironic node-set-provision-state $NODE active

$ ironic node-show $NODE | grep properties
| properties | {u'capabilities': u'boot_mode:uefi'}

This defect applies to all iLO drivers.

It should not update the 'boot_mode' in properties/capabilities, but should internally take it as the uefi boot mode.

This could lead to failure if the boot mode that gets set internally happens to be BIOS when secure boot is requested by the user.

Tags: ilo
summary: boot_mode capability is overwritten in node properties/capabilities
- when secure boot is requested
+ when secure boot is requested for iLO drivers
description: updated
description: updated
summary: - boot_mode capability is overwritten in node properties/capabilities
- when secure boot is requested for iLO drivers
+ boot_mode is overwritten in node properties/capabilities when secure
+ boot is requested for iLO drivers
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167952

Changed in ironic:
assignee: nobody → Shivanand Tendulker (shivanand-tendulker)
status: New → In Progress
description: updated
Changed in ironic:
milestone: none → kilo-rc1
importance: Undecided → Medium
Dmitry Tantsur (divius)
tags: added: ilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/167952
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=53df7893f08aa96d9694393bf45bf77fb2aa11e2
Submitter: Jenkins
Branch: master

commit 53df7893f08aa96d9694393bf45bf77fb2aa11e2
Author: Shivanand Tendulker <email address hidden>
Date: Thu Mar 26 03:02:37 2015 -0700

    boot_mode is overwritten in node properties

    iLO drivers overwrite boot_mode in the node's properties/capabilities
    when UEFI secure boot is requested.

    Closes-Bug: 1436791

    Change-Id: I9b6cf288b34707a8a1d5d99a95f2bc9f6bf380f1

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.