Ironic

Agent driver may deploy or clean a maintenanced node

Bug #1436569 reported by Jim Rollenhagen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Jim Rollenhagen
Ironic 2015.1.0 "kilo"

Bug Description

The vendor passthru heartbeat() method doesn't check if a node is in maintenance before continuing a deploy or clean function.

Tags: agent
Jim Rollenhagen (jim-rollenhagen)
Changed in ironic:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167801

Changed in ironic:
assignee: nobody → Jim Rollenhagen (jim-rollenhagen)
status: New → In Progress
Dmitry Tantsur (divius)
tags: added: agent
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/167801
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=42b533856618e9940967ab87f0a9cb5973673f8b
Submitter: Jenkins
Branch: master

commit 42b533856618e9940967ab87f0a9cb5973673f8b
Author: Josh Gachnang <email address hidden>
Date: Fri Jan 23 11:38:51 2015 -0800

    Agent driver: no-op heartbeat for maintenanced node

    There may be a race where a node begins deploy or cleaning, but is
    maintenanced (for whatever reason) before the ramdisk boots and reports
    back. A node in maintenance mode should not be touched by Ironic.

    No-op the heartbeat method when a node is in maintenance mode. Rather
    than failing immediately, allow the agent to continue heartbeating with
    the hope that it is taken out of maintenance mode soon.

    Co-Author: Jim Rollenhagen <email address hidden>
    Closes-Bug: #1436569
    Change-Id: Ib461e1c2652a4a55c112b62eea9b3d5492c33b63

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
milestone: none → kilo-rc1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.