Ironic

Nova cannot remove instance uuid from node during cleaning

Bug #1435605 reported by Josh Gachnang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Josh Gachnang
Ironic 2015.1.0 "kilo"

Bug Description

As soon as Nova moves the node's provision state to DELETING, it
attempts to remove the instance UUID. Ironic throws an error because
it considers the node in a state transition. If cleaning takes longer
than the Nova timeout, the delete will error out.

Josh Gachnang (joshnang)
Changed in ironic:
assignee: nobody → Josh Gachnang (joshnang)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/167033

Changed in ironic:
status: New → In Progress
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → High
milestone: none → kilo-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/167033
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=47c58ea9bf0d7d6bdd3aa03785bc2c71c048b2e1
Submitter: Jenkins
Branch: master

commit 47c58ea9bf0d7d6bdd3aa03785bc2c71c048b2e1
Author: Josh Gachnang <email address hidden>
Date: Mon Mar 23 15:48:37 2015 -0700

    Allow node.instance_uuid to be removed during cleaning

    As soon as Nova moves the node's provision state to DELETING, it
    attempts to remove the node's instance UUID. Ironic throws an error
    because it considers the node in a state transition. If cleaning
    takes longer than the Nova timeout, the delete will error out.

    The fix is to allow node.instance_uuid removal while the node is in
    CLEANING state. In L, we should fix the Nova driver to not remove
    node.instance_uuid, and clear it after tear down when we clear out
    node.instance_info.

    Also allows updates to nodes in CLEANFAIL to match the other states
    in UPDATE_ALLOWED_STATES, and if the node fails CLEANING quickly, the
    node.instance_uuid removal could happen here.

    Change-Id: I46771041f90a1d52f6b2d8e107ca10b650b720c1
    Closes-Bug: 1435605

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.